Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the confusing preview tab on wiki editor #14457

Closed
wants to merge 1 commit into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 25, 2021

Fix #14196

Since there is already a button on toolbar to preview, it's unnecessary to add another tab to preview because it's confusing.

@BLumia
Copy link
Member

BLumia commented Jan 25, 2021

This seems will not fix #14196 since that bug only happens on 1.13.1, not on the master branch, and it's caused by 4f296f7. I do think removing the preview tab makes sense to me, but marking this patch as a fix for that issue is very confusing.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 25, 2021
@noerw
Copy link
Member

noerw commented Jan 26, 2021

Not sure what is confusing about that tab, it is consistent with other markdown input UI, and until recently I didn't even discover this toolbar button.

@lunny lunny closed this Jan 29, 2021
@lunny lunny deleted the lunny/remove_confusing_preview branch January 29, 2021 14:37
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The WYSIWYG editor and preview do not work in Wiki
4 participants