Add fullTextSearch to dropdowns by default #14694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds `fullTextSearch: 'exact'` to most dropdown invocations meaning that if there is a search box for the dropdown it will automatically do a fullTextSearch looking for the provided fragment instead of starting at the beginning We should consider changing other places that use `fullTextSearch: true` to `'exact'` because these will be using a fuzzy-textual search that doesn't necessarily return the expected results. Fix go-gitea#14689 Signed-off-by: Andrew Thornton <art27@cantab.net>
|
I've put this as 1.14 because it's a rather simple change - I am happy for it to be pushed to 1.15 if preferred. |
GiteaBot
added
the
lgtm/need 2
lafriks
approved these changes
Feb 15, 2021
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Feb 16, 2021
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
fullTextSearch: 'exact'to most dropdowninvocations meaning that if there is a search box for the
dropdown it will automatically do a fullTextSearch looking
for the provided fragment instead of starting at the beginning
We should consider changing other places that use
fullTextSearch: trueto'exact'because these will be using afuzzy-textual search that doesn't necessarily return the
expected results.
Fix #14689
Signed-off-by: Andrew Thornton art27@cantab.net