Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

anchor links in gitea rendered md file don't work #14968

Closed
1 of 2 tasks
Bubu opened this issue Mar 12, 2021 · 1 comment · Fixed by #14969
Closed
1 of 2 tasks

anchor links in gitea rendered md file don't work #14968

Bubu opened this issue Mar 12, 2021 · 1 comment · Fixed by #14969
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.13.5

Comments

@Bubu
Copy link

Bubu commented Mar 12, 2021 •
edited

  • Gitea version (or commit ref): 1.13.4+15-g7aaa02e22 (codeberg.org)

  • Git version: ?

  • Operating system: Archlinux

  • Can you reproduce the bug at https://try.gitea.io:

    • Yes
    • No

Description

This link which you get by clicking on the anchor icon in the markdown heading in this file doesn't jump to the right section when loading the page again:

https://try.gitea.io/Bubu/TEST/src/branch/main/FAQ_de.md#warum-ben%C3%B6tigt-die-app-zugriff-auf-meinen-standort

Screenshots

image
@fnetX
Copy link
Contributor

fnetX commented Mar 12, 2021

Probably related to the Umlauts in the text. Works when adding the user-content-Prefix: https://try.gitea.io/Bubu/TEST/src/branch/main/FAQ_de.md#user-content-warum-ben%C3%B6tigt-die-app-zugriff-auf-meinen-standort

zeripath added a commit to zeripath/gitea that referenced this issue Mar 12, 2021
@zeripath
Fix Anchor jumping with escaped query components
4582897 
Fix go-gitea#14968

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Mar 12, 2021
Merged
@zeripath zeripath added this to the 1.13.5 milestone Mar 12, 2021
@zeripath zeripath added type/bug topic/ui Change the appearance of the Gitea UI labels Mar 12, 2021
zeripath added a commit that referenced this issue Mar 12, 2021
@zeripath
Fix Anchor jumping with escaped query components (#14969)
ff1bccf 
Fix #14968

Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added a commit to zeripath/gitea that referenced this issue Mar 12, 2021
@zeripath
Fix Anchor jumping with escaped query components (go-gitea#14969)
51b02b4 
Backport go-gitea#14969

Fix go-gitea#14968

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Mar 12, 2021
Merged
zeripath added a commit that referenced this issue Mar 13, 2021
@zeripath
Fix Anchor jumping with escaped query components (#14969) (#14977)
71a2adb 
Backport #14969

Fix #14968

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.13.5
Development

Successfully merging a pull request may close this issue.

Fix Anchor jumping with escaped query components zeripath/gitea
3 participants
@Bubu @zeripath @fnetX