Skip to content

Fix Anchor jumping with escaped query components (#14969) #14977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2021
Merged

Fix Anchor jumping with escaped query components (#14969) #14977

merged 2 commits into from
Mar 13, 2021

Conversation

zeripath
Copy link
Contributor

Backport #14969

Fix #14968

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Fix Anchor jumping with escaped query components (go-gitea#14969)
51b02b4 
Backport go-gitea#14969

Fix go-gitea#14968

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/bug topic/ui Change the appearance of the Gitea UI labels Mar 12, 2021
@zeripath zeripath added this to the 1.13.5 milestone Mar 12, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 12, 2021
@kdumontnu kdumontnu self-requested a review March 13, 2021 02:32
kdumontnu
kdumontnu approved these changes Mar 13, 2021
View reviewed changes
Copy link
Contributor

@kdumontnu kdumontnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 13, 2021
@zeripath
Copy link
Contributor Author

make lgtm work

@zeripath zeripath merged commit 71a2adb into go-gitea:release/v1.13 Mar 13, 2021
@zeripath zeripath deleted the backport-14969 branch March 13, 2021 09:54
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@noerw noerw noerw approved these changes

@kdumontnu kdumontnu kdumontnu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.13.5
Development

Successfully merging this pull request may close these issues.
4 participants
@zeripath @noerw @kdumontnu @GiteaBot