Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

borked button alignment #15097

Closed
noerw opened this issue Mar 21, 2021 · 2 comments · Fixed by #15214
Closed

borked button alignment #15097

noerw opened this issue Mar 21, 2021 · 2 comments · Fixed by #15214
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@noerw
Copy link
Member

noerw commented Mar 21, 2021 •
edited
Loading

  • Gitea version (or commit ref): 1.15.0+dev-6-g17731e05f

Description

aaand another button alignment regression: this time the "view resolved comments" button on /<pwner>/<repo>/pulls/<idx>/files:
grafik
@noerw noerw added type/bug topic/ui Change the appearance of the Gitea UI labels Mar 21, 2021
@silverwind
Copy link
Member

Need to flexbox this.

@silverwind silverwind mentioned this issue Mar 30, 2021
Merged
@silverwind
Copy link
Member

#15214

silverwind added a commit to silverwind/gitea that referenced this issue Mar 30, 2021
@silverwind
Diff box fixes
d3e3da5 
- Fix misaligned "Show Outdated" buttons via flexbox
- Add hover effect to "Show Outdated" buttons
- Remove overreaching margin from selector .diff-file-box and handle
  cases individually.

Fixes: go-gitea#15097
techknowlogick added a commit that referenced this issue Mar 31, 2021
@silverwind @lunny
@6543 @zeripath @techknowlogick
Diff box fixes (#15214)
aee5ef0 
- Fix misaligned "Show Outdated" buttons via flexbox
- Add hover effect to "Show Outdated" buttons
- Remove overreaching margin from selector .diff-file-box and handle
  cases individually.

Fixes: #15097

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
silverwind added a commit to silverwind/gitea that referenced this issue Mar 31, 2021
@silverwind @lunny
@6543 @zeripath @techknowlogick
Diff box fixes (go-gitea#15214)
f370185 
- Fix misaligned "Show Outdated" buttons via flexbox
- Add hover effect to "Show Outdated" buttons
- Remove overreaching margin from selector .diff-file-box and handle
  cases individually.

Fixes: go-gitea#15097

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
lafriks pushed a commit that referenced this issue Apr 1, 2021
@silverwind @lunny
@6543 @zeripath @techknowlogick
Diff box fixes (#15214) (#15227)
5c7d30c 
- Fix misaligned "Show Outdated" buttons via flexbox
- Add hover effect to "Show Outdated" buttons
- Remove overreaching margin from selector .diff-file-box and handle
  cases individually.

Fixes: #15097

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this issue Aug 10, 2021
@silverwind @lunny
@6543 @zeripath @techknowlogick @AbdulrhmnGhanem
Diff box fixes (go-gitea#15214)
ca93ca7 
- Fix misaligned "Show Outdated" buttons via flexbox
- Add hover effect to "Show Outdated" buttons
- Remove overreaching margin from selector .diff-file-box and handle
  cases individually.

Fixes: go-gitea#15097

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Diff box fixes silverwind/gitea
2 participants
@silverwind @noerw