Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff box fixes (#15214) #15227

Merged
merged 2 commits into from
Apr 1, 2021
Merged

Diff box fixes (#15214) #15227

merged 2 commits into from
Apr 1, 2021

Conversation

silverwind
Copy link
Member

Backport #15214 to 1.14.

@silverwind @lunny
@6543 @zeripath @techknowlogick
Diff box fixes (go-gitea#15214)
f370185 
- Fix misaligned "Show Outdated" buttons via flexbox
- Add hover effect to "Show Outdated" buttons
- Remove overreaching margin from selector .diff-file-box and handle
  cases individually.

Fixes: go-gitea#15097

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@techknowlogick techknowlogick added this to the 1.14.0 milestone Mar 31, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 31, 2021
@6543 6543 added type/bug topic/ui Change the appearance of the Gitea UI labels Mar 31, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 1, 2021
@lafriks lafriks merged commit 5c7d30c into go-gitea:release/v1.14 Apr 1, 2021
@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 1, 2021
@silverwind silverwind deleted the backport-15214 branch April 1, 2021 07:18
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@6543 6543 6543 approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@silverwind @lafriks @6543 @a1012112796 @techknowlogick @GiteaBot