Favicon not used when viewing files

[FWDekker]

Gitea Version

1.15.9

Operating System

FreeBSD 13

Browser Version

Firefox 98.0

Can you reproduce the bug on the Gitea demo site?

No

Description

Cannot reproduce at try.gitea.io because it does not use a non-standard favicon. See this file on my self-hosted Gitea instance as an example.

When looking at a file directly in the browser, such as an avatar or PDF file, the default favicon is used instead of the custom favicon. At least in Firefox, the browser displays the favicon at example.com/favicon.ico when viewing a file. On HTML pages, the browser correctly uses example.com/assets/img/logo.svg.

I have configured the favicon by adding the files favicon.ico, favicon.png, logo.png, and logo.svg to $GITEA_CUSTOM/public/img/.

Screenshots

On the left: correct favicon is used for an HTML page.
On the right: default favicon is used for an image.

[silverwind]

Favicons are now SVG, so /favicon.ico route is unused and it redirects to root. It might be possible to redirect /favicon.ico to /assets/img/logo.svg file in case the browser would accept that. Or possible just serve the SVG on that route directly.

[techknowlogick]

Probably a redirect would be better so that browsers don't hit both and cache both

[abheekda1]

If this isn't already being tackled and someone is willing to give a pointer I'd be happy to take a look at fixing this issue :)

[silverwind]

You can add the redirect right after

gitea/routers/web/web.go

Lines 97 to 100 in 04fcf23

	// this png is very likely to always be below the limit for gzip so it doesn't need to pass through gzip
	routes.Get("/apple-touch-icon.png", func(w http.ResponseWriter, req *http.Request) {
	http.Redirect(w, req, path.Join(setting.StaticURLPrefix, "/assets/img/apple-touch-icon.png"), 301)
	})

:

Note that I'm not sure if browser are going to accept such a redirect on favicon, but it's worth a try and won't hurt even if it's there.

[abheekda1]

Seems that the correct favicon is stored at /assets/img/favicon.ico so I'm going to give a redirect to that location a shot.

[abheekda1]

@silverwind it seems that the custom favicon at that path does not exist if the default one is used, meaning that redirecting to it may result in no favicon at all. Is there a better implementation that should allow me to remedy that?

Here's my current solution:

	routes.Get("/favicon.ico", func(w http.ResponseWriter, req *http.Request) {
		faviconPath := ""
		res, err := http.Get(path.Join(setting.StaticURLPrefix, "/assets/img/favicon.ico"))
		if err != nil || res.StatusCode != 200 {
			faviconPath = "/favicon.ico"
		} else {
			faviconPath = "/assets/img/favicon.ico"
		}
		http.Redirect(w, req, path.Join(setting.StaticURLPrefix, faviconPath), 301)
	})

[FWDekker]

Awesome! Thank you, all! :-)