Issue totals are wrong when filtering by team

[jpraet]

Description

The issue totals for "Assigned to you", "Created by you" and "Mentioning you" are incorrect in the statistics when filtering on team, when the current filter is "In your repositories".

When selecting another filter, they are correct:

I recently upgraded from 1.16.4 to 1.16.7, and I believe it may be a regression in #18916.

Gitea Version

1.16.7

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

No response

[Gusted]

Yup seems to be a regression from #18916. Not really able to debug this, but if anyone wants to give a try models.SearchRepositoryCondition(repoOpts) seems to be the faulty here, it's returning the incorrect repoID's.

[wxiaoguang]

Maybe it's caused by that the RepoCond is applied too early.

		if filterMode == models.FilterModeYourRepositories {
			statsOpts.RepoCond = models.SearchRepositoryCondition(repoOpts)
		}
		// GetUserIssueStats needs to count all kinds of issues like YourRepositoriesCount / AssignCount / CreateCount
		// however, the statsOpts.RepoCond has been limited by FilterModeYourRepositories
		issueStats, err = models.GetUserIssueStats(statsOpts)

[jpraet]

gitea/routers/web/user/home.go

Lines 601 to 604 in 0eac09e

	// Detect when we only should search by team.
	if opts.User == nil {
	statsOpts.UserID = 0
	}

By setting the UserID to 0 the stats for assigned / created / mention cannot work.

[Gusted]

Maybe it's caused by that the RepoCond is applied too early.

		if filterMode == models.FilterModeYourRepositories {
			statsOpts.RepoCond = models.SearchRepositoryCondition(repoOpts)
		}
		// GetUserIssueStats needs to count all kinds of issues like YourRepositoriesCount / AssignCount / CreateCount
		// however, the statsOpts.RepoCond has been limited by FilterModeYourRepositories
		issueStats, err = models.GetUserIssueStats(statsOpts)

Yes good catch. The overall issueStats should be independent of the filterMode 😅.

By setting the UserID to 0 the stats for assigned / created / mention cannot work.

Why not? It only makes sense for 'created', as you cannot create a issue as team. But you can mention/assign a team to a issue/PR. It actually seems like providing a 'created' item here is not correct.

[Gusted]

#19652 refactors the code a bit and fixes the issue.

[jpraet]

By setting the UserID to 0 the stats for assigned / created / mention cannot work.

Why not? It only makes sense for 'created', as you cannot create a issue as team. But you can mention/assign a team to a issue/PR. It actually seems like providing a 'created' item here is not correct.

Ah, but this is not how this used to work before. With the dropdown box you can select to filter by team repositories:

• "Assigned to you" shows the issues/pulls assigned to you in those team repo's
• "Created by you" shows the issues/pulls you created in those team repo's
• "Mentioning you" shows the issues/pulls mentioning you in those team repo's
• "Review requested" shows the pulls in those team repo's that request your review