Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: CSS import code snippet for external renderers does not work #22434

Closed
sbannier opened this issue Jan 13, 2023 · 1 comment
Closed
Labels

Comments

@sbannier
Copy link
Contributor

Description

The documentation gives this code snippet (see https://github.com/go-gitea/gitea/blob/main/docs/content/doc/advanced/external-renderers.en-us.md?plain=1#L195)
<link type="text/css" href="{{AppSubUrl}}/assets/css/my-style-XXXXX.css" />

In Firefox and Chrome this did not work and the CSS was not applied to the rendered HTML page.

Adding rel="stylesheet" to the link tag solved the issue for both browsers:
<link rel="stylesheet" type="text/css" href="{{AppSubUrl}}/assets/css/my-style-XXXXX.css" />

I will also add a pull request including the changes.

Gitea Version

1.16.4

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

Windows

How are you running Gitea?

We are are using the prebuilt Gitea binaries on a Windows 2019 server.

Database

None

zeripath pushed a commit that referenced this issue Jan 13, 2023
)

The documentation is missing the rel attribute. Neither Firefox nor
Chrome did use the linked file as CSS if rel="stylesheet" is not set.

The problem is described in issue #22434.

Co-authored-by: silverwind <me@silverwind.io>
@lunny
Copy link
Member

lunny commented Jan 19, 2023

closed by #22435

@lunny lunny closed this as completed Jan 19, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants