Fix stylesheet HTML snippet for external renderers documentation #22435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation is missing the rel attribute. Neither Firefox nor Chrome did use the linked file as CSS if rel="stylesheet" is not set.
silverwind
reviewed
Jan 13, 2023
GiteaBot
added
the
lgtm/need 2
GiteaBot
added
lgtm/need 1
text/css seems to be the default type, so this information is redundant. Co-authored-by: silverwind <me@silverwind.io>
|
Thanks for the feedback, I changed the code as proposed by you. Shall I squash both commits or is the PR good the way it is now? |
|
Not necessary as we squash on merge. |
zeripath
approved these changes
Jan 13, 2023
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 16, 2023
* upstream/main: Prevent panic on looking at api "git" endpoints for empty repos (go-gitea#22457) Restore previous official review when an official review is deleted (go-gitea#22449) Add support for incoming emails (go-gitea#22056) Fix stylesheet HTML snippet for external renderers documentation (go-gitea#22435) Log STDERR of external renderer when it fails (go-gitea#22442) Fix error when calculate the repository size (go-gitea#22392) clarify "open issues" text for labels (go-gitea#22431) Restore function to "Show more" buttons (go-gitea#22399)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation is missing the rel attribute. Neither Firefox nor Chrome did use the linked file as CSS if rel="stylesheet" is not set.
The problem is described in issue #22434.