You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think the GetOwner here should be LoadOwner. Get means return something and Load means something is nil, we need to load it.
This func dosen't return anything, but the description of this func says GetOwner returns the repository owner
The text was updated successfully, but these errors were encountered:
yp05327
added
type/feature
Completely new functionality. Can only be merged if feature freeze is not active.
type/proposal
The new feature has not been accepted yet but needs to be discussed first.
labels
Feb 18, 2023
lunny
added
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
and removed
type/proposal
The new feature has not been accepted yet but needs to be discussed first.
type/feature
Completely new functionality. Can only be merged if feature freeze is not active.
labels
Feb 18, 2023
Feature Description
I think the
GetOwner
here should beLoadOwner
.Get
means return something andLoad
means something isnil
, we need to load it.This func dosen't return anything, but the description of this func says
GetOwner returns the repository owner
gitea/models/repo/repo.go
Lines 376 to 384 in 8bba7e3
In other places, the functions which do samething are called
LoadOwner
gitea/models/project/project.go
Lines 110 to 116 in 8bba7e3
gitea/models/admin/task.go
Lines 95 to 112 in 8bba7e3
Screenshots
No response
The text was updated successfully, but these errors were encountered: