Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme: release descripton doesn't look good #23718

Closed
wxiaoguang opened this issue Mar 26, 2023 · 2 comments · Fixed by #23750
Closed

Dark theme: release descripton doesn't look good #23718

wxiaoguang opened this issue Mar 26, 2023 · 2 comments · Fixed by #23750
Labels

Comments

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Mar 26, 2023

Description

https://try.gitea.io/wxiaoguang/test/releases

  1. Padding/Margin
  2. Background color

image

@zeripath
Copy link
Contributor

zeripath commented Mar 26, 2023

in comments the markup gets a border:

.comment-body .markup {
  padding: 1em;
  border-radius: 0 0 var(--border-radius) var(--border-radius); /* don't render outside box */
}

We could just add gt-px-3 gt-py-3 to the class?

I guess the question is how to ensure it looks ok in the non-arc-green theme

@wxiaoguang
Copy link
Contributor Author

I think it's caused by incorrect background color (introduced by https://github.com/go-gitea/gitea/pull/23578/files#r1149604909 )

Without the background: var(--color-box-body); or use inherit, the UI looks fine.

silverwind added a commit that referenced this issue Apr 7, 2023
Fix regression from #23578. Only
visible on arc-green.

Before:
<img width="997" alt="Screenshot 2023-03-27 at 19 14 21"
src="https://user-images.githubusercontent.com/115237/228016589-e7cabfb9-bfd0-45fd-9407-6b76c665ed1a.png">

After:
<img width="1000" alt="Screenshot 2023-03-27 at 19 14 05"
src="https://user-images.githubusercontent.com/115237/228016600-db2e6002-4e2c-4d18-8393-9d7e1f525acb.png">

Fixes: #20625
Fixes: #23718
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants