Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reverse-proxy document and fix nginx config bug #24616

Merged
merged 7 commits into from
May 10, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented May 9, 2023

Close #23711, thanks to @ghnp5 !
Close #24612, thanks to @DanielGibson !

Major changes:

  • the default value of nginx's client_max_body_size is too small, so put a 512M here
  • move Resolving Error: 413 Request Entity Too Large to a sub-section of Nginx section
  • make nginx use unescaped the URI and keep "%2F" as is when using sub-path
  • add details for General sub-path configuration

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 9, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 9, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 9, 2023
@silverwind
Copy link
Member

Am a bit sceptical regarding thowse rewrites, but I don't know another solution off my head at least because nginx slash handling is generally weird.

@DanielGibson
Copy link

I think the documentation on client_max_body_size could be more explicit about it not only affecting file uploads in the webui, but also via git when using LFS (=> keep the If you use Git LFS, this will also limit the size of the largest file you will be able to push. sentence from the prior version).
For lazy people who don't want to look at the nginx doc you could also mention the special case of 0 meaning no limit ;)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 10, 2023
@lunny lunny added the type/docs This PR mainly updates/creates documentation label May 10, 2023
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented May 10, 2023

I think the documentation on client_max_body_size could be more explicit about it not only affecting file uploads in the webui,

8298848

For lazy people who don't want to look at the nginx doc you could also mention the special case of 0 meaning no limit ;)

"nolimit" would fill up user's disk if the user runs nginx with tmp dir in a small file system.

@wolfogre wolfogre added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 10, 2023
@lunny lunny enabled auto-merge (squash) May 10, 2023 03:58
auto-merge was automatically disabled May 10, 2023 04:10

Head branch was pushed to by a user without write access

@lunny lunny enabled auto-merge (squash) May 10, 2023 05:23
@lunny lunny merged commit cf1a7b0 into go-gitea:main May 10, 2023
@GiteaBot GiteaBot added this to the 1.20.0 milestone May 10, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 10, 2023
@wxiaoguang wxiaoguang deleted the fix-proxy-doc branch May 10, 2023 06:51
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 11, 2023
* upstream/main:
  Fix typo in act-runner file (go-gitea#24652)
  RSS icon fixes (go-gitea#24476)
  Notification list enhancements, fix striped tables on dark theme (go-gitea#24639)
  Improve "goto issue by number" button (go-gitea#24577)
  Increase default LFS auth timeout from 20m to 24h (go-gitea#24628)
  Fix typo in the swift package documentation (go-gitea#24637)
  Fix broken links in documents (go-gitea#24630)
  Improve updating Actions tasks (go-gitea#24600)
  Modify luminance calculation and extract related functions into single files (go-gitea#24586)
  Do not send "registration success email" for external auth sources (go-gitea#24632)
  Fix typo in Actions demo file (go-gitea#24631)
  Review fixes and enhancements (go-gitea#24526)
  Remove fluid on compare diff page (go-gitea#24627)
  Make the actions control button look like an actual button (go-gitea#24611)
  Add a tooltip to the job rerun button (go-gitea#24617)
  Improve reverse-proxy document and fix nginx config bug (go-gitea#24616)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/docs This PR mainly updates/creates documentation
Projects
None yet
7 participants