Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix document and improve comment #24844

Merged
merged 7 commits into from May 22, 2023
Merged

Fix document and improve comment #24844

merged 7 commits into from May 22, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented May 22, 2023 •
edited

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 22, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 22, 2023
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 22, 2023
@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label May 22, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 22, 2023
silverwind
silverwind reviewed May 22, 2023
View reviewed changes
web_src/css/base.css Outdated Show resolved Hide resolved
@silverwind silverwind changed the title Fix document and improve commennt Fix document and improve comment May 22, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 22, 2023
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 22, 2023
@silverwind silverwind enabled auto-merge (squash) May 22, 2023 07:04
silverwind
silverwind reviewed May 22, 2023
View reviewed changes
web_src/css/base.css Outdated Show resolved Hide resolved
silverwind
silverwind reviewed May 22, 2023
View reviewed changes
web_src/css/base.css Outdated Show resolved Hide resolved
silverwind
silverwind reviewed May 22, 2023
View reviewed changes
web_src/css/base.css Outdated Show resolved Hide resolved
@yp05327
Copy link
Contributor

yp05327 commented May 22, 2023 •
edited

#24827 will be reverted in #24852.

@silverwind silverwind merged commit bb9e20e into go-gitea:main May 22, 2023
31 checks passed
@GiteaBot GiteaBot added this to the 1.20.0 milestone May 22, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 22, 2023
@wxiaoguang wxiaoguang deleted the fix-doc-comment branch May 22, 2023 09:06
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 23, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
f0522e1 
* upstream/main:
  Fix install page context, make the install page tests really test (go-gitea#24858)
  Add validations.required check to dropdown field (go-gitea#24849)
  Use Go 1.20 for next release (go-gitea#24859)
  Add gitea manager reload-templates command (go-gitea#24843)
  Remove `In your repositories` link in milestones dashboard (go-gitea#24853)
  Fix 500 error when select `No assignee` filter in issue list page (go-gitea#24854)
  Add IsErrRepoFilesAlreadyExist check when fork repo (go-gitea#24678)
  Fix missing yes/no in delete time log modal (go-gitea#24851)
  Fix document and improve comment (go-gitea#24844)

# Conflicts:
#	web_src/css/base.css
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wxiaoguang @yp05327 @lunny @silverwind @techknowlogick @GiteaBot