Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean expire package not clean all #25035

Closed
wenerme opened this issue Jun 1, 2023 · 7 comments
Closed

Clean expire package not clean all #25035

wenerme opened this issue Jun 1, 2023 · 7 comments
Labels
issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea topic/packages

Comments

@wenerme
Copy link

wenerme commented Jun 1, 2023

Description

I want to clean up the expired packages, but run once only clean a little.

Gitea Version

1.9.3

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

image
image
image
image
image
image
image

Git Version

No response

Operating System

No response

How are you running Gitea?

Kube deolpy

Database

PostgreSQL
@sillyguodong
Copy link
Contributor

Please change the language to English before taking the screenshot...

@KN4CK3R KN4CK3R added issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail topic/packages and removed type/bug labels Jun 6, 2023
@KN4CK3R
Copy link
Member

KN4CK3R commented Jun 13, 2023

I think you ran into https://docs.gitea.com/packages/usage/packages/storage#deduplication

These unreferenced blobs get deleted by a clean up job. The config setting OLDER_THAN configures how long unreferenced blobs are kept before they get deleted.

The blobs are only deleted after 24h with the default value.

@wenerme
Copy link
Author

wenerme commented Jun 13, 2023

@KN4CK3R The problem is I run clean expire package, every click/run will delete some packages, that means, the clean not delete all in once.

@KN4CK3R
Copy link
Member

KN4CK3R commented Jun 15, 2023

Because only unreferenced blobs are deleted which are older then 24h at the time of the click.

@KN4CK3R KN4CK3R mentioned this issue Jun 16, 2023
Merged
@KN4CK3R KN4CK3R mentioned this issue Jul 28, 2023
Closed
silverwind added a commit that referenced this issue Aug 8, 2023
@KN4CK3R @silverwind
Allow package cleanup from admin page (#25307)
0c6ae61 
Until now expired package data gets deleted daily by a cronjob. The
admin page shows the size of all packages and the size of unreferenced
data. The users (#25035, #20631) expect the deletion of this data if
they run the cronjob from the admin page but the job only deletes data
older than 24h.

This PR adds a new button which deletes all expired data.

![grafik](https://github.com/go-gitea/gitea/assets/1666336/b3e35d73-9496-4fa7-a20c-e5d30b1f6850)

---------

Co-authored-by: silverwind <me@silverwind.io>
@yardenshoham yardenshoham mentioned this issue Sep 8, 2023
Merged
@GiteaBot
Copy link
Contributor

GiteaBot commented Sep 8, 2023

We close issues that need feedback from the author if there were no new comments for a month. 🍵

@GiteaBot GiteaBot closed this as completed Sep 8, 2023
@wenerme
Copy link
Author

wenerme commented Sep 8, 2023 •
edited

Problem still exists, 1.20.3

image

Click

image image

Click

image image

@lunny lunny removed the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Sep 8, 2023
@lunny lunny reopened this Sep 8, 2023
@KN4CK3R
Copy link
Member

KN4CK3R commented Sep 8, 2023

#25307 is only in 1.21

@KN4CK3R KN4CK3R added the issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea label Sep 8, 2023
@KN4CK3R KN4CK3R closed this as completed Sep 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea topic/packages
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lunny @KN4CK3R @wenerme @GiteaBot @sillyguodong