-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close issues with status/needs-feedback
that were last updated more than a month ago
#108
Conversation
… than a month ago We will close issues that have the label `status/needs-feedback` if there was no new activity in the past month.
Co-authored-by: silverwind <me@silverwind.io>
Should we need authors' response or anyone's response will be OK? |
The check is for any update to the issue |
And take a look at go-gitea/gitea#23071 , @delvh has commented after the label added? |
Yes, but there was no activity. Do you prefer it will stay open even if there is no activity? |
For that issue, I think it should be kept open because it's a feature. Maybe we should add another label That is if it's a bug report but there is a needs-feedback label but there is no response from author for a month? |
I think we should simply remove |
Looks most closings are right. |
console.log(`Closing issue #${issue.number} due to feedback timeout`); | ||
await addComment( | ||
issue.number, | ||
`We close issues that need feedback from the author if there were no new comments for a month. :tea:`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems somewhat unfriendly imo.
This issue has the
status/needs-feedback
label and hasn't received activity in a month or more, so it is being closed. If you feel this was in error (misplaced label or otherwise), please let us know so we can re-evaluate. If you are not the original author, consider opening a new issue linking to this one instead.
Or something along those lines? The current wording seems very strong to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, send a PR to change it
I agree with this, however as humans I think it will be imperfect, so I think (as in my review) that perhaps the wording could be a little softer in the event an issue is closed in error. |
I don't like that. There are only a few issues with that label, not really a place for automation. |
@lunny requested it, so I implemented it. If it causes trouble I don't mind reverting this PR |
I think it could be feasible, however currently our usage of the label is probably inconsistent. |
I have checked all closed issues, I think most of them are expected. It can give us a reminder the author has no response for a report. |
The real problem is that not enough people are reviewing the issue list regularly. So only a few "needs-feedback" would be added. |
We will close issues with the label
status/needs-feedback
if there is no new activity in the past month.