Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close issues with status/needs-feedback that were last updated more than a month ago #108

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

yardenshoham
Copy link
Collaborator

We will close issues with the label status/needs-feedback if there is no new activity in the past month.

… than a month ago

We will close issues that have the label `status/needs-feedback` if there was no new activity in the past month.
@yardenshoham
Copy link
Collaborator Author

Issues that will get closed:

Issues that will remain open:

src/feedback.ts Outdated Show resolved Hide resolved
src/feedback.ts Outdated Show resolved Hide resolved
Co-authored-by: silverwind <me@silverwind.io>
@yardenshoham yardenshoham merged commit aab91a4 into main Sep 8, 2023
2 checks passed
@yardenshoham yardenshoham deleted the issues/106 branch September 8, 2023 12:29
@lunny
Copy link
Collaborator

lunny commented Sep 8, 2023

Should we need authors' response or anyone's response will be OK?

@yardenshoham
Copy link
Collaborator Author

The check is for any update to the issue

@lunny
Copy link
Collaborator

lunny commented Sep 8, 2023

And take a look at go-gitea/gitea#23071 , @delvh has commented after the label added?

@yardenshoham
Copy link
Collaborator Author

Yes, but there was no activity. Do you prefer it will stay open even if there is no activity?

@lunny
Copy link
Collaborator

lunny commented Sep 8, 2023

Yes, but there was no activity. Do you prefer it will stay open even if there is no activity?

For that issue, I think it should be kept open because it's a feature. Maybe we should add another label bug.

That is if it's a bug report but there is a needs-feedback label but there is no response from author for a month?

@yardenshoham
Copy link
Collaborator Author

I think we should simply remove status/needs-feedback from issues that should remain open...

@lunny
Copy link
Collaborator

lunny commented Sep 8, 2023

Looks most closings are right.

console.log(`Closing issue #${issue.number} due to feedback timeout`);
await addComment(
issue.number,
`We close issues that need feedback from the author if there were no new comments for a month. :tea:`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems somewhat unfriendly imo.

This issue has the status/needs-feedback label and hasn't received activity in a month or more, so it is being closed. If you feel this was in error (misplaced label or otherwise), please let us know so we can re-evaluate. If you are not the original author, consider opening a new issue linking to this one instead.

Or something along those lines? The current wording seems very strong to me.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, send a PR to change it

@jolheiser
Copy link
Collaborator

I think we should simply remove status/needs-feedback from issues that should remain open...

I agree with this, however as humans I think it will be imperfect, so I think (as in my review) that perhaps the wording could be a little softer in the event an issue is closed in error.

@KN4CK3R
Copy link

KN4CK3R commented Sep 8, 2023

I don't like that. There are only a few issues with that label, not really a place for automation.

@yardenshoham
Copy link
Collaborator Author

@lunny requested it, so I implemented it. If it causes trouble I don't mind reverting this PR

@jolheiser
Copy link
Collaborator

I think it could be feasible, however currently our usage of the label is probably inconsistent.

@lunny
Copy link
Collaborator

lunny commented Sep 8, 2023

I have checked all closed issues, I think most of them are expected. It can give us a reminder the author has no response for a report.

@wxiaoguang
Copy link

The real problem is that not enough people are reviewing the issue list regularly. So only a few "needs-feedback" would be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A new label to close an issue if there are 1 month no response after the label marked.
6 participants