Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual highlight glitch #27604

Closed
KN4CK3R opened this issue Oct 13, 2023 · 2 comments · Fixed by #27697
Closed

Visual highlight glitch #27604

KN4CK3R opened this issue Oct 13, 2023 · 2 comments · Fixed by #27697
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@KN4CK3R
Copy link
Member

KN4CK3R commented Oct 13, 2023 •
edited
Loading

Description

On the PR file page the file highlight border is not hidden.

Screenshots

grafik

grafik
(on the right side of the button)

Browser Version

Firefox 118
@KN4CK3R KN4CK3R added type/bug topic/ui Change the appearance of the Gitea UI labels Oct 13, 2023
@silverwind
Copy link
Member

You mean hide behind the sticky header? I imagine we could enlarge it to 100% width.

@KN4CK3R
Copy link
Member Author

KN4CK3R commented Oct 13, 2023

Yes, if you scroll down the border scrolls into the header. The top border is hidden.

@silverwind silverwind mentioned this issue Oct 19, 2023
Merged
6543 pushed a commit that referenced this issue Oct 20, 2023
@silverwind
Fix sticky diff header background (#27697)
4539a7b 
Fixes: #27604

Add negative margins so the header covers any shadow of active elements.
No rendering change of the content of the header because the padding
counteracts the effect.

<img width="128" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/3d0f55b6-9351-4985-a290-da9a92d15b4e">
@GiteaBot GiteaBot mentioned this issue Oct 20, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Oct 20, 2023
@silverwind @GiteaBot
Fix sticky diff header background (go-gitea#27697)
7249799 
Fixes: go-gitea#27604

Add negative margins so the header covers any shadow of active elements.
No rendering change of the content of the header because the padding
counteracts the effect.

<img width="128" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/3d0f55b6-9351-4985-a290-da9a92d15b4e">
silverwind added a commit that referenced this issue Oct 20, 2023
@GiteaBot @silverwind
Fix sticky diff header background (#27697) (#27712)
345d70f 
Backport #27697 by @silverwind

Fixes: #27604

Add negative margins so the header covers any shadow of active elements.
No rendering change of the content of the header because the padding
counteracts the effect.

<img width="128" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/3d0f55b6-9351-4985-a290-da9a92d15b4e">

Co-authored-by: silverwind <me@silverwind.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2023
silverwind added a commit to silverwind/gitea that referenced this issue Feb 20, 2024
@silverwind
Fix sticky diff header background (go-gitea#27697)
3eb7b46 
Fixes: go-gitea#27604

Add negative margins so the header covers any shadow of active elements.
No rendering change of the content of the header because the padding
counteracts the effect.

<img width="128" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/3d0f55b6-9351-4985-a290-da9a92d15b4e">
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sticky diff header background silverwind/gitea
2 participants
@silverwind @KN4CK3R