Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force shutting down panic #28062

Closed
lunny opened this issue Nov 15, 2023 · 3 comments
Closed

Force shutting down panic #28062

lunny opened this issue Nov 15, 2023 · 3 comments
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail type/bug

Comments

@lunny
Copy link
Member

lunny commented Nov 15, 2023

version: 1.21.0

2023/11/15 11:48:43 ...eful/manager_unix.go:198:handleSignals() [W] PID 9476. Received SIGTERM. Shutting down...
2023/11/15 11:48:43 ...eful/server_hooks.go:46:doShutdown() [I] PID: 9476 Listener ([::]:80) closed.
2023/11/15 11:48:43 ...eful/server_hooks.go:46:doShutdown() [I] PID: 9476 Listener ([::]:443) closed.
2023/11/15 11:49:43 .../graceful/manager.go:168:doHammerTime() [W] Setting Hammer condition
2023/11/15 11:49:43 ...eful/server_hooks.go:63:doHammer() [W] Forcefully shutting down parent
2023/11/15 11:49:43 ...eful/server_hooks.go:57:func1() [E] WaitGroup at 0: Error: sync: negative WaitGroup counter
2023/11/15 11:49:43 cmd/web.go:231:func1() [F] PANIC: sync: WaitGroup is reused before previous Wait has returned
/usr/local/go/src/sync/waitgroup.go:118 (0x480d13)
/source/modules/graceful/server.go:177 (0xa992a5)
/source/modules/graceful/server.go:160 (0xa9903e)
/source/modules/graceful/server_http.go:39 (0xa9a37b)
/source/cmd/web_https.go:190 (0x282cc7c)
/source/cmd/web_acme.go:122 (0x282cc25)
/source/cmd/web.go:323 (0x282bfb4)
/source/cmd/web.go:212 (0x282b106)
/source/cmd/web.go:262 (0x282b5fc)
/source/cmd/main.go:117 (0x28220cb)
/go/pkg/mod/github.com/urfave/cli/v2@v2.25.7/command.go:274 (0x13440d7)
/go/pkg/mod/github.com/urfave/cli/v2@v2.25.7/command.go:267 (0x1344324)
/go/pkg/mod/github.com/urfave/cli/v2@v2.25.7/app.go:332 (0x1340a56)
/go/pkg/mod/github.com/urfave/cli/v2@v2.25.7/app.go:309 (0x2822cd8)
/source/cmd/main.go:176 (0x2822cbc)
/source/main.go:46 (0x2868d58)
/usr/local/go/src/runtime/proc.go:267 (0x4400ba)
/usr/local/go/src/runtime/asm_amd64.s:1650 (0x473ca0)
@lunny lunny added the type/bug label Nov 15, 2023
@wxiaoguang
Copy link
Contributor

A similar (but not the same) problem: #27643

The graceful manager/server have some data-race bugs.

wxiaoguang added a commit that referenced this issue Nov 15, 2023
The graceful manager has some bugs (#27643, #28062). This is a
preparation for further fixes.
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this issue Jan 17, 2024
The graceful manager has some bugs (go-gitea#27643, go-gitea#28062). This is a
preparation for further fixes.
silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 20, 2024
The graceful manager has some bugs (go-gitea#27643, go-gitea#28062). This is a
preparation for further fixes.
@lunny
Copy link
Member Author

lunny commented Mar 31, 2024

I think this has been resolved by #29738

@lunny lunny added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Mar 31, 2024
@GiteaBot
Copy link
Contributor

We close issues that need feedback from the author if there were no new comments for a month. 🍵

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail type/bug
Projects
None yet
Development

No branches or pull requests

3 participants