Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve graceful manager code/comment #28063

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Improve graceful manager code/comment #28063

merged 1 commit into from
Nov 15, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Nov 15, 2023 •
edited
Loading

The graceful manager has some bugs (#27643, #28062). This is a preparation for further fixes.

This PR only moves some code, removes dead code, improve comments, there should be no logic change.

@wxiaoguang wxiaoguang added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Nov 15, 2023
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Nov 15, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 15, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 15, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 15, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 15, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 15, 2023
@wxiaoguang wxiaoguang merged commit 79394b3 into go-gitea:main Nov 15, 2023
25 checks passed
@wxiaoguang wxiaoguang deleted the refactor-graceful-manager branch November 15, 2023 14:02
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 15, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 16, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
468b192 
* giteaofficial/main:
  Improve PR diff view on mobile (go-gitea#27883)
  Improve graceful manager code/comment (go-gitea#28063)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@wxiaoguang @fuxiaohei
Improve graceful manager code/comment (go-gitea#28063)
674788b 
The graceful manager has some bugs (go-gitea#27643, go-gitea#28062). This is a
preparation for further fixes.
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wxiaoguang @lunny @delvh @GiteaBot