Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to pass PostgreSQL connection params #28083

Closed
PKizzle opened this issue Nov 16, 2023 · 3 comments · Fixed by #28085
Closed

Unable to pass PostgreSQL connection params #28083

PKizzle opened this issue Nov 16, 2023 · 3 comments · Fixed by #28085
Labels
type/bug

Comments

@PKizzle
Copy link

PKizzle commented Nov 16, 2023 •
edited

Description

With the recent changes in https://github.com/go-gitea/gitea/blame/79394b340d227182f94bae48cb08a091c78f2ea2/modules/setting/database.go#L160C6-L160C35 it is no longer possible to specify custom connection parameters like binary_parameters=yes by appending them to the Database.Name.
Instead of the actual parameters the parameter separator is passed to getPostgreSQLConnectionString.

Gitea Version

v1.21.0

Can you reproduce the bug on the Gitea demo site?

No - irrelevant since issue is configuration related

How are you running Gitea?

Helm chart v9.5.1 on Kubernetes cluster v1.28.3

Database

PostgreSQL
@lunny
Copy link
Member

lunny commented Nov 16, 2023

related #27723

@wxiaoguang wxiaoguang mentioned this issue Nov 16, 2023
Merged
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Nov 16, 2023 •
edited

-> Fix incorrect pgsql conn builder behavior #28085

I guess you meant that Name = "name?key=val", while it's better to provide your real config example, it would help to clarify the problem.

@PKizzle
Copy link
Author

PKizzle commented Nov 16, 2023

I need to add this parameter in order to connect to the PostgreSQL database via pgbouncer.

My database is named gitea hence I set NAME to gitea?binary_parameters=yes.

silverwind pushed a commit that referenced this issue Nov 17, 2023
@wxiaoguang
Fix incorrect pgsql conn builder behavior (#28085)
17d246c 
Fix #28083 and fix the tests
@GiteaBot GiteaBot mentioned this issue Nov 17, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Nov 17, 2023
@wxiaoguang @GiteaBot
Fix incorrect pgsql conn builder behavior (go-gitea#28085)
f97d373 
Fix go-gitea#28083 and fix the tests
silverwind pushed a commit that referenced this issue Nov 17, 2023
@GiteaBot @wxiaoguang
Fix incorrect pgsql conn builder behavior (#28085) (#28098)
f7567f7 
Backport #28085 by @wxiaoguang

Fix #28083 and fix the tests

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2024
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this issue Jan 17, 2024
@wxiaoguang @fuxiaohei
Fix incorrect pgsql conn builder behavior (go-gitea#28085)
14d01a9 
Fix go-gitea#28083 and fix the tests
silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 20, 2024
@wxiaoguang @silverwind
Fix incorrect pgsql conn builder behavior (go-gitea#28085)
e59b505 
Fix go-gitea#28083 and fix the tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect pgsql conn builder behavior wxiaoguang/gitea
3 participants
@lunny @wxiaoguang @PKizzle