Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect pgsql conn builder behavior #28085

Merged
merged 2 commits into from Nov 17, 2023
Merged

Fix incorrect pgsql conn builder behavior #28085

merged 2 commits into from Nov 17, 2023

Conversation

wxiaoguang
Copy link
Contributor

Fix #28083 and fix the tests

@wxiaoguang wxiaoguang added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 labels Nov 16, 2023
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Nov 16, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 16, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 16, 2023
@wxiaoguang wxiaoguang mentioned this pull request Nov 16, 2023
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 16, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 17, 2023
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 17, 2023
@silverwind silverwind enabled auto-merge (squash) November 17, 2023 02:06
@silverwind silverwind merged commit 17d246c into go-gitea:main Nov 17, 2023
25 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 17, 2023
@GiteaBot GiteaBot mentioned this pull request Nov 17, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Nov 17, 2023
@wxiaoguang @GiteaBot
Fix incorrect pgsql conn builder behavior (go-gitea#28085)
f97d373 
Fix go-gitea#28083 and fix the tests
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Nov 17, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 17, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
a9be4ef 
* giteaofficial/main:
  Fix incorrect pgsql conn builder behavior (go-gitea#28085)
  Fix system config cache expiration timing (go-gitea#28072)
silverwind pushed a commit that referenced this pull request Nov 17, 2023
@GiteaBot @wxiaoguang
Fix incorrect pgsql conn builder behavior (#28085) (#28098)
f7567f7 
Backport #28085 by @wxiaoguang

Fix #28083 and fix the tests

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@wxiaoguang wxiaoguang deleted the fix-pgsql-conn branch November 18, 2023 14:13
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@wxiaoguang @fuxiaohei
Fix incorrect pgsql conn builder behavior (go-gitea#28085)
14d01a9 
Fix go-gitea#28083 and fix the tests
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Unable to pass PostgreSQL connection params
4 participants
@wxiaoguang @lunny @silverwind @GiteaBot