Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Minimum Key Size Check shown as × despite MINIMUM_KEY_SIZE_CHECK = false #30019

Closed
lwlwlwlw opened this issue Mar 23, 2024 · 1 comment · Fixed by #30024
Closed

Disable Minimum Key Size Check shown as × despite MINIMUM_KEY_SIZE_CHECK = false #30019

lwlwlwlw opened this issue Mar 23, 2024 · 1 comment · Fixed by #30024
Labels
type/bug

Comments

@lwlwlwlw
Copy link

lwlwlwlw commented Mar 23, 2024 •
edited

Description

"Disable Minimum Key Size Check" is shown as × when MINIMUM_KEY_SIZE_CHECK = false,
and it is shown as ✓ when MINIMUM_KEY_SIZE_CHECK = true or absent,
at page "http://server:port/admin/config"

I assume the opposite is correct.

Gitea Version

1.21.9

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Gitea on Windows 10 22H2.

Database

None
@wxiaoguang
Copy link
Contributor

It has been fixed by Remove duplicate option in admin screen and now-unused translation keys #28492 , but not backported ....

@wxiaoguang wxiaoguang mentioned this issue Mar 23, 2024
Merged
@wxiaoguang wxiaoguang linked a pull request Mar 23, 2024 that will close this issue
Remove duplicate option in admin screen and now-unused translation keys (#28492) #30024
Merged
silverwind pushed a commit that referenced this issue Mar 23, 2024
@wxiaoguang @TheMagician23
Remove duplicate option in admin screen and now-unused translation ke…
01f736f 
…ys (#28492) (#30024)

Backport #28492
Fix #30019

Co-authored-by: The Magician <142242365+TheMagician23@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove duplicate option in admin screen and now-unused translation keys (#28492) wxiaoguang/gitea
2 participants
@wxiaoguang @lwlwlwlw