Remove duplicate option in admin screen and now-unused translation keys #28492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TheMagician23 I noticed you've updated the locales for non-English languages. These will be overwritten during the sync from our translation tool Crowdin. If you'd like to contribute your translations, please visit https://crowdin.com/project/gitea. Please revert the changes done on these files. 🍵 |
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
|
Can someone please let me know if I need to revert removing the translations from the non-English files? I'm not 100% sure if the bot's recommendation holds since I'm removing unused keys instead of changing translations. |
|
Yes, they will be autoremoved, the bot is correct. |
pull-request-size
bot
added
size/XS
|
@delvh Thanks. I've pushed a commit to only change the English file. |
delvh
approved these changes
Dec 16, 2023
GiteaBot
added
lgtm/need 1
wxiaoguang
approved these changes
Dec 16, 2023
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 19, 2023
* giteaofficial/main: [skip ci] Updated translations via Crowdin Add option to disable ambiguous unicode characters detection (go-gitea#28454) Adjust object format interface (go-gitea#28469) Remove duplicate option in admin screen and now-unused translation keys (go-gitea#28492) [skip ci] Updated translations via Crowdin Initalize stroage for orphaned repository doctor (go-gitea#28487)
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
…ys (go-gitea#28492) Resolves go-gitea#28451. This change follows the recommendation by wxiaoguang to remove the "Disable Minimum Key Size Check" from the "Service Configuration" section of the UI, because this option belongs to the "SSH Configuration" section of the administration menu and already has a functioning indicator in that section of the UI. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
…ys (go-gitea#28492) Resolves go-gitea#28451. This change follows the recommendation by wxiaoguang to remove the "Disable Minimum Key Size Check" from the "Service Configuration" section of the UI, because this option belongs to the "SSH Configuration" section of the administration menu and already has a functioning indicator in that section of the UI. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
lunny
added
backport/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #28451.
This change follows the recommendation by @wxiaoguang to remove the "Disable Minimum Key Size Check" from the "Service Configuration" section of the UI, because this option belongs to the "SSH Configuration" section of the administration menu and already has a functioning indicator in that section of the UI.
I've also removed all of the translation keys that were associated with the removed section as they are now entirely unused.