Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong alignment in branch view #30142

Closed
KN4CK3R opened this issue Mar 27, 2024 · 3 comments · Fixed by #30144
Closed

Wrong alignment in branch view #30142

KN4CK3R opened this issue Mar 27, 2024 · 3 comments · Fixed by #30144
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@KN4CK3R
Copy link
Member

KN4CK3R commented Mar 27, 2024 •
edited
Loading

Was working some days ago.

grafik

@silverwind May be related to #30047.
@KN4CK3R KN4CK3R added type/bug topic/ui Change the appearance of the Gitea UI labels Mar 27, 2024
@silverwind
Copy link
Member

silverwind commented Mar 27, 2024 •
edited
Loading

Definitely related. The element here has two alignment classes right aligned middle aligned and I guess the order of rules must have changed so that middle now wins over right 😆.

@silverwind
Copy link
Member

Nevermind, middle is actually vertical alignment, must be something else, checking...

@silverwind silverwind mentioned this issue Mar 27, 2024
Merged
@silverwind
Copy link
Member

#30144

silverwind added a commit that referenced this issue Mar 27, 2024
@silverwind
Fix table alignment classes (#30144)
b08c7af 
Fixes #30142, regression from
#30047. I searched the codebase
and only `bottom aligned` was definitely not in use so I removed it.
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Mar 30, 2024
@silverwind @earl-warren
Fix table alignment classes (#30144)
c5ac296 
Fixes go-gitea/gitea#30142, regression from
go-gitea/gitea#30047. I searched the codebase
and only `bottom aligned` was definitely not in use so I removed it.

(cherry picked from commit b08c7afe5f60075ed62a5ffe034b88624983d007)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix table alignment classes silverwind/gitea
2 participants
@silverwind @KN4CK3R