-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable unparam
linter
#31277
Merged
Merged
Enable unparam
linter
#31277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually I think i will change many of these |
Ready now, the only cases where underscore prop was applicable was in the webhook files. Other errors are more complex and many involve static return values or cases where a value is passed through a function unmodified. |
delvh
reviewed
Jun 10, 2024
Co-authored-by: delvh <dev.lh@web.de>
lunny
reviewed
Jun 11, 2024
silverwind
commented
Jun 11, 2024
lunny
approved these changes
Jun 11, 2024
delvh
approved these changes
Jun 11, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 12, 2024
* giteaofficial/main: Fix go-gitea#31185 try fix lfs download from bitbucket failed (go-gitea#31201) Enable `unparam` linter (go-gitea#31277) Make template `Iif` exactly match `if` (go-gitea#31322) update nix flake and add gofumpt (go-gitea#31320) code optimization (go-gitea#31315)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/api
This PR adds API routes or modifies them
modifies/go
Pull requests that update Go code
modifies/internal
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
topic/code-linting
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable unparam linter.
Often I could not tell the intention why param is unused, so I put
//nolint
for those cases like webhook request creation functions never usingctx
.