Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code optimization #31315

Merged
merged 6 commits into from
Jun 11, 2024
Merged

code optimization #31315

merged 6 commits into from
Jun 11, 2024

Conversation

kerwin612
Copy link
Member

Simplifying complex if-else to existing Iif operations

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 11, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 11, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Jun 11, 2024
@kerwin612 kerwin612 requested review from delvh and 6543 and removed request for delvh June 11, 2024 03:25
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 11, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 11, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 11, 2024
@wxiaoguang wxiaoguang merged commit e6ab6e6 into go-gitea:main Jun 11, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Jun 11, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 12, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
66bf728 
* giteaofficial/main:
  Fix go-gitea#31185 try fix lfs download from bitbucket failed (go-gitea#31201)
  Enable `unparam` linter (go-gitea#31277)
  Make template `Iif` exactly match `if` (go-gitea#31322)
  update nix flake and add gofumpt (go-gitea#31320)
  code optimization (go-gitea#31315)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

@6543 6543 Awaiting requested review from 6543

@delvh delvh Awaiting requested review from delvh

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kerwin612 @lunny @wxiaoguang @GiteaBot