Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook Url too long in UI #5416

Closed
2 of 7 tasks
xoxys opened this issue Nov 27, 2018 · 0 comments · Fixed by #5432
Closed
2 of 7 tasks

Webhook Url too long in UI #5416

xoxys opened this issue Nov 27, 2018 · 0 comments · Fixed by #5432
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.6.1

Comments

@xoxys
Copy link
Contributor

xoxys commented Nov 27, 2018 •
edited
Loading

  • Gitea version (or commit ref): 1.6.0
  • Git version:
  • Operating system: Linux
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant

Description

If the URL for a webhook is too long it will run out of the UI. Maybe a forced word-wrap could fix it.

Screenshots

image
@lunny lunny added type/bug topic/ui Change the appearance of the Gitea UI labels Nov 27, 2018
r-52 added a commit to r-52/gitea that referenced this issue Nov 30, 2018
@r-52
word-break the WebHook url to prevent a ui-break
23cc5c2 
right now, the url is displayed with an anchor tag with no classes. If
the url is really really long, the url will break out of the containing
div and (depending on the url length) the browser shows the horizontal
scrollbar.
This pr makes use of the already existing css class `dont-break-out`
which gives all the anchor the necessary properties to prevent the
break.
Another solution could be to introduce some classes like
`text text-break-word`, but that would duplicate the `dont-break-out`
class just for text elements that use the `text` class.

fixes: go-gitea#5416
Signed-off-by: Roman <romaaan.git@gmail.com>
@r-52 r-52 mentioned this issue Nov 30, 2018
Merged
techknowlogick pushed a commit that referenced this issue Nov 30, 2018
@romankl @techknowlogick
word-break the WebHook url to prevent a ui-break (#5432)
06ef5b6 
right now, the url is displayed with an anchor tag with no classes. If
the url is really really long, the url will break out of the containing
div and (depending on the url length) the browser shows the horizontal
scrollbar.
This pr makes use of the already existing css class `dont-break-out`
which gives all the anchor the necessary properties to prevent the
break.
Another solution could be to introduce some classes like
`text text-break-word`, but that would duplicate the `dont-break-out`
class just for text elements that use the `text` class.

fixes: #5416
Signed-off-by: Roman <romaaan.git@gmail.com>
@lafriks lafriks added this to the 1.6.1 milestone Nov 30, 2018
r-52 added a commit to r-52/gitea that referenced this issue Dec 2, 2018
@r-52
word-break the WebHook url to prevent a ui-break
dbc1484 
right now, the url is displayed with an anchor tag with no classes. If
the url is really really long, the url will break out of the containing
div and (depending on the url length) the browser shows the horizontal
scrollbar.
This pr makes use of the already existing css class `dont-break-out`
which gives all the anchor the necessary properties to prevent the
break.
Another solution could be to introduce some classes like
`text text-break-word`, but that would duplicate the `dont-break-out`
class just for text elements that use the `text` class.

fixes: go-gitea#5416
Signed-off-by: Roman <romaaan.git@gmail.com>
@r-52 r-52 mentioned this issue Dec 2, 2018
Merged
techknowlogick pushed a commit that referenced this issue Dec 2, 2018
@romankl @techknowlogick
word-break the WebHook url to prevent a ui-break (#5445)
7bc1faa 
right now, the url is displayed with an anchor tag with no classes. If
the url is really really long, the url will break out of the containing
div and (depending on the url length) the browser shows the horizontal
scrollbar.
This pr makes use of the already existing css class `dont-break-out`
which gives all the anchor the necessary properties to prevent the
break.
Another solution could be to introduce some classes like
`text text-break-word`, but that would duplicate the `dont-break-out`
class just for text elements that use the `text` class.

fixes: #5416
Signed-off-by: Roman <romaaan.git@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.6.1
Development

Successfully merging a pull request may close this issue.

word-break the WebHook url to prevent a ui-break r-52/gitea
3 participants
@lunny @lafriks @xoxys