Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script contributor tests #6269

Closed
stevegt opened this issue Mar 7, 2019 · 5 comments
Closed

Script contributor tests #6269

stevegt opened this issue Mar 7, 2019 · 5 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@stevegt
Copy link
Contributor

stevegt commented Mar 7, 2019

We keep regressing in CONTRIBUTING.md. This time, it's starting to look like at least some contributors may not have been able to run drone tests since October 2018 (#6243). The last time we touched this was back in #4053, #4055, #4070, and #4071.

I think we need to:

Both of these are handled by #6305.

@stevegt stevegt changed the title Containerize and automatically run contributor tests Script and automatically run contributor tests Mar 8, 2019
stevegt added a commit to stevegt/gitea that referenced this issue Mar 11, 2019
- fixes go-gitea#6243
- partial fix for go-gitea#6269

Signed-off-by: Steve Traugott <stevegt@t7a.org>
@stevegt stevegt changed the title Script and automatically run contributor tests Script and automatically verify contributor tests Mar 11, 2019
@stevegt stevegt changed the title Script and automatically verify contributor tests Script contributor tests Mar 17, 2019
@stevegt
Copy link
Contributor Author

stevegt commented Mar 17, 2019

I've trimmed this issue; it originally included a suggestion that we run the script automatically at PR submission to ensure the script itself stays updated. If that gets done it should probably be handled as a separate discussion and/or project.

@stevegt
Copy link
Contributor Author

stevegt commented Mar 17, 2019

I've removed the script from PR #6305 -- if anyone is looking for it, you can grab a copy at https://github.com/stevegt/gitea/blob/drone-cli-bash/scripts/test-local.sh.

The script only runs on Linux and should be replaced with a go version for portability; I'll work on that if nobody else gets to it first.

lunny pushed a commit that referenced this issue Mar 18, 2019
* add scripts/test-local.sh and fix CONTRIBUTING.md

- fixes #6243
- partial fix for #6269

Signed-off-by: Steve Traugott <stevegt@t7a.org>

* remove reference to possible automated drone run

* remove bash version of drone-cli test script

* fix issue number links in testing instructions

* remove scripts/test-local.sh
@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Mar 18, 2019
@stevegt
Copy link
Contributor Author

stevegt commented May 11, 2019

Touching to make stale bot happy -- have been getting myself up to speed on go while working on another project; haven't forgotten about this.

@lunny
Copy link
Member

lunny commented May 12, 2019

Now we have used drone 1.x, so the CONTRIBUTING.md should also be updated again.

@wxiaoguang
Copy link
Contributor

Now the development of Gitea doesn't need Drone, make works well.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

3 participants