Handle CORS requests #6289

tamalsaha · 2019-03-09T12:33:17Z

modules/setting/cors.go

Signed-off-by: Tamal Saha <tamal@appscode.com>

codecov-io · 2019-03-09T19:18:11Z

Codecov Report

Merging #6289 into master will increase coverage by 0.01%.
The diff coverage is 81.81%.

@@            Coverage Diff            @@
##           master   #6289      +/-   ##
=========================================
+ Coverage   41.38%   41.4%   +0.01%     
=========================================
  Files         440     441       +1     
  Lines       59703   59736      +33     
=========================================
+ Hits        24709   24734      +25     
- Misses      31758   31762       +4     
- Partials     3236    3240       +4

Impacted Files	Coverage Δ
modules/setting/setting.go	`47.67% <100%> (+0.09%)`	⬆️
routers/api/v1/api.go	`70.56% <76.92%> (+0.13%)`	⬆️
modules/setting/cors.go	`84.21% <84.21%> (ø)`
modules/log/event.go	`64.46% <0%> (-1.53%)`	⬇️
models/repo_list.go	`66.84% <0%> (-1.06%)`	⬇️
models/gpg_key.go	`55.83% <0%> (-0.84%)`	⬇️
routers/repo/view.go	`43.03% <0%> (+1.01%)`	⬆️
models/unit.go	`67.56% <0%> (+5.4%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb58a8...0c56e5f. Read the comment docs.

modules/setting/cors.go

techknowlogick

A few more items to be addressed.

techknowlogick · 2019-04-16T17:48:06Z

@tamalsaha could you resolve git conflicts, update to use go modules, add tests, and update per feedback? If you do not have any available time to do so please let us know and I can take over this PR to make the required changes.

tamalsaha · 2019-04-17T12:49:21Z

@techknowlogick, please feel free to make changes as you see fit. My bandwidth is tight for next few weeks. Thanks!

tamalsaha · 2019-04-18T21:59:12Z

go.mod

@@ -136,5 +137,6 @@ require (

 replace (
 	github.com/denisenkom/go-mssqldb v0.0.0-20181014144952-4e0d7dc8888f => github.com/denisenkom/go-mssqldb v0.0.0-20161128230840-e32ca5036449
+	github.com/go-macaron/cors v0.0.0-20190309005821-1733aeedd68a => github.com/tamalsaha/cors v0.0.0-20190309005821-1733aeedd68a


Why is this replace needed? https://github.com/go-macaron/cors is up-todate with github.com/tamalsaha/cors

See: go-macaron/cors#1
it fails otherwise

@techknowlogick , I just updated go-macaron/cors@6fd6a9b . Please revendor . This should be fixed.

Thanks for fix 😄

tamalsaha · 2019-04-23T22:26:29Z

@techknowlogick , do you plan to make any more changes? I wonder when this will be merged.

techknowlogick · 2019-04-23T22:27:46Z

@tamalsaha my changes are done, and only one other review is needed. Once a 2nd LG-TM is given then this can be merged.

FallingSnow · 2019-05-11T00:24:43Z

Is there anything we can do to accelerate a 2nd LG-TM?

lunny · 2019-05-11T02:01:16Z

Please resolve the conflicts.

# Conflicts: # Gopkg.lock # routers/api/v1/api.go

tamalsaha · 2019-05-13T08:49:22Z

go.mod

@@ -135,6 +136,6 @@ require (
 )

 replace (
-	github.com/denisenkom/go-mssqldb v0.0.0-20181014144952-4e0d7dc8888f => github.com/denisenkom/go-mssqldb v0.0.0-20161128230840-e32ca5036449
-	github.com/go-sql-driver/mysql v1.4.0 => github.com/go-sql-driver/mysql v0.0.0-20181218123637-c45f530f8e7f
+	github.com/denisenkom/go-mssqldb => github.com/denisenkom/go-mssqldb v0.0.0-20161128230840-e32ca5036449


I am following the syntax from https://github.com/golang/go/wiki/Modules#when-should-i-use-the-replace-directive

tamalsaha · 2019-05-13T09:31:36Z

@lunny , I have fixed the conflicts. PTAL.

techknowlogick reviewed Mar 9, 2019

View reviewed changes

modules/setting/cors.go Show resolved Hide resolved

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 9, 2019

techknowlogick added type/enhancement An improvement of existing functionality modifies/api This PR adds API routes or modifies them labels Mar 9, 2019

techknowlogick added this to the 1.9.0 milestone Mar 9, 2019

Handle CORS requests

e35c3a3

Signed-off-by: Tamal Saha <tamal@appscode.com>

techknowlogick reviewed Mar 23, 2019

View reviewed changes

modules/setting/cors.go Outdated Show resolved Hide resolved

techknowlogick reviewed Mar 23, 2019

View reviewed changes

modules/setting/cors.go Show resolved Hide resolved

techknowlogick requested changes Mar 23, 2019

View reviewed changes

techknowlogick added 18 commits April 17, 2019 15:55

Merge remote-tracking branch 'upstream/master' into cors-pr

aa8b18b

add vendor

1b7326a

add docs

0e20860

use time.Duration

cdcc350

follow struct

1e9267f

cast to int

f98e157

sample tests

4e355d7

update tests

941cbeb

disable cors for disabled cors test

77ed706

make fmt

d21cafa

make session

34811f7

change func

ffd17b1

map

30c74e3

blank

a1fd528

func

747d397

set default to true

c2d32bb

refactor

9caf3ee

disable by default

095e52c

techknowlogick added 5 commits April 17, 2019 19:31

make fmt

beba88f

refactor

ab866c3

appropriate log message

035c36f

remove not needed lib

a3633f2

better name of func

7cd4f34

techknowlogick approved these changes Apr 18, 2019

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 18, 2019

Merge branch 'master' into cors-pr

c995452

tamalsaha commented Apr 18, 2019

View reviewed changes

techknowlogick and others added 2 commits April 18, 2019 18:46

Update go.mod

aee5375

go get

b369256

techknowlogick and others added 2 commits April 23, 2019 18:27

Merge branch 'master' into cors-pr

4525788

Merge branch 'master' into cors-pr

e3d5742

Merge remote-tracking branch 'upstream/master' into cors-pr

0c56e5f

# Conflicts: # Gopkg.lock # routers/api/v1/api.go

tamalsaha commented May 13, 2019

View reviewed changes

lunny approved these changes May 13, 2019

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 13, 2019

techknowlogick merged commit 34d06f4 into go-gitea:master May 13, 2019

tamalsaha deleted the cors-pr branch May 13, 2019 15:52

go-gitea locked and limited conversation to collaborators Nov 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle CORS requests #6289

Handle CORS requests #6289

tamalsaha commented Mar 9, 2019 •

edited by techknowlogick

Loading

codecov-io commented Mar 9, 2019 •

edited

Loading

techknowlogick left a comment

techknowlogick commented Apr 16, 2019

tamalsaha commented Apr 17, 2019

tamalsaha Apr 18, 2019

techknowlogick Apr 18, 2019

tamalsaha Apr 18, 2019

techknowlogick Apr 18, 2019

tamalsaha commented Apr 23, 2019

techknowlogick commented Apr 23, 2019

FallingSnow commented May 11, 2019

lunny commented May 11, 2019

tamalsaha May 13, 2019

tamalsaha commented May 13, 2019

Handle CORS requests #6289

Handle CORS requests #6289

Conversation

tamalsaha commented Mar 9, 2019 • edited by techknowlogick Loading

codecov-io commented Mar 9, 2019 • edited Loading

Codecov Report

techknowlogick left a comment

Choose a reason for hiding this comment

techknowlogick commented Apr 16, 2019

tamalsaha commented Apr 17, 2019

tamalsaha Apr 18, 2019

Choose a reason for hiding this comment

techknowlogick Apr 18, 2019

Choose a reason for hiding this comment

tamalsaha Apr 18, 2019

Choose a reason for hiding this comment

techknowlogick Apr 18, 2019

Choose a reason for hiding this comment

tamalsaha commented Apr 23, 2019

techknowlogick commented Apr 23, 2019

FallingSnow commented May 11, 2019

lunny commented May 11, 2019

tamalsaha May 13, 2019

Choose a reason for hiding this comment

tamalsaha commented May 13, 2019

tamalsaha commented Mar 9, 2019 •

edited by techknowlogick

Loading

codecov-io commented Mar 9, 2019 •

edited

Loading