Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle CORS requests #6289

Open
wants to merge 1 commit into
base: master
from

Conversation

4 participants
@tamalsaha
Copy link

tamalsaha commented Mar 9, 2019

Fixes #5724

Handle CORS requests
Signed-off-by: Tamal Saha <tamal@appscode.com>

@tamalsaha tamalsaha force-pushed the tamalsaha:cors-pr branch from 4d73021 to e35c3a3 Mar 9, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 9, 2019

Codecov Report

Merging #6289 into master will decrease coverage by <.01%.
The diff coverage is 54.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6289      +/-   ##
==========================================
- Coverage   38.88%   38.87%   -0.01%     
==========================================
  Files         359      360       +1     
  Lines       51018    51049      +31     
==========================================
+ Hits        19836    19845       +9     
- Misses      28312    28334      +22     
  Partials     2870     2870
Impacted Files Coverage Δ
modules/setting/setting.go 47.11% <100%> (+0.09%) ⬆️
modules/setting/cors.go 35.29% <35.29%> (ø)
routers/api/v1/api.go 73.97% <76.92%> (+0.07%) ⬆️
models/unit.go 0% <0%> (-14.29%) ⬇️
models/repo_list.go 66.84% <0%> (-1.06%) ⬇️
routers/repo/view.go 41.08% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fffb06...e35c3a3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.