Fix error log when loading issues caused by a xorm bug #7271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
force-pushed
the
lunny/fix_rows_err
branch
from
9078856
to
02a91a9
Compare
zeripath
reviewed
Jun 22, 2019
GiteaBot
added
the
lgtm/need 2
lunny
force-pushed
the
lunny/fix_rows_err
branch
from
02a91a9
to
5f6ebcf
Compare
Codecov Report
@@ Coverage Diff @@
## master #7271 +/- ##
==========================================
- Coverage 41.17% 41.17% -0.01%
==========================================
Files 464 464
Lines 62771 62761 -10
==========================================
- Hits 25846 25839 -7
+ Misses 33537 33528 -9
- Partials 3388 3394 +6
Continue to review full report at Codecov.
|
sapk
approved these changes
Jun 23, 2019
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Jun 23, 2019
GiteaBot
added
lgtm/done
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
* fix error log when loading issues caused by a xorm bug * upgrade packages * fix fmt * fix Consistency * fix tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, when
rows.Close, xorm always complainedsql: no rows, that has been fixedon go-xorm/xorm#1334. This PR will fix that wrong error log.And this will upgrade xorm, mssql, mysql packages