Move code.gitea.io/gitea/modules/log to code.gitea.io/log as a standalone package #6970

lunny · 2019-05-17T05:31:22Z

This PR will move code.gitea.io/gitea/modules/log to code.gitea.io/log as a standalone package so that other projects (i.e. tea) could use the log package but not import all the gitea packages.

techknowlogick

please change imports to "code.gitea.io/log"

techknowlogick · 2019-05-30T04:05:16Z

cmd/admin.go

@@ -15,7 +15,7 @@ import (
 	"code.gitea.io/gitea/modules/auth/oauth2"
 	"code.gitea.io/gitea/modules/generate"
 	"code.gitea.io/gitea/modules/git"
-	"code.gitea.io/gitea/modules/log"
+	"gitea.com/gitea/log"


Suggested change

"gitea.com/gitea/log"

"code.gitea.io/log"

codecov-io · 2019-06-01T13:03:24Z

Codecov Report

Merging #6970 into master will decrease coverage by 0.65%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master    #6970      +/-   ##
==========================================
- Coverage   40.98%   40.32%   -0.66%     
==========================================
  Files         462      446      -16     
  Lines       62584    61376    -1208     
==========================================
- Hits        25648    24749     -899     
+ Misses      33574    33303     -271     
+ Partials     3362     3324      -38

Impacted Files	Coverage Δ
models/unit.go	`67.56% <ø> (+5.4%)`	⬆️
models/repo.go	`48.35% <ø> (ø)`	⬆️
modules/migrations/migrate.go	`23.35% <ø> (ø)`	⬆️
models/u2f.go	`63.15% <ø> (ø)`	⬆️
models/admin.go	`81.63% <ø> (ø)`	⬆️
routers/init.go	`65.33% <ø> (ø)`	⬆️
routers/private/hook.go	`47.95% <ø> (ø)`	⬆️
models/branches.go	`50% <ø> (ø)`	⬆️
models/migrations/v45.go	`0% <ø> (ø)`	⬆️
models/repo_branch.go	`49.53% <ø> (ø)`	⬆️
... and 143 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d145955...99fac9b. Read the comment docs.

lunny · 2019-06-01T13:06:14Z

Ready to review.

zeripath · 2019-06-01T14:24:47Z

If we can get #6993 in first we can get rid of the gitlog weirdness too.

lunny · 2019-06-02T02:25:21Z

@zeripath rebased

zeripath · 2019-06-02T08:40:02Z

Thanks @lunny.

…dalone package

stale · 2019-08-22T10:34:19Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

guillep2k · 2019-08-22T21:49:49Z

models/consistency.go

@@ -39,7 +39,7 @@ func CheckConsistencyFor(t *testing.T, beansToCheck ...interface{}) {
 		ptrToSliceValue := reflect.New(sliceType)
 		ptrToSliceValue.Elem().Set(sliceValue)

-		assert.NoError(t, x.Where(bean).Find(ptrToSliceValue.Interface()))
+		assert.NoError(t, x.Table(bean).Find(ptrToSliceValue.Interface()))


This is relevant?

I will open a new PR to instead this one. It's unrelated but should be a bug.

@lunny can you reverence the PR to tis bugfix?

for the log -> #7271

tamalsaha · 2019-08-24T04:25:40Z

I wonder if gitea could switch to https://github.com/go-logr/logr which defines a logging interface. Then you can plug in https://github.com/uber-go/zap using https://github.com/go-logr/zapr . zap is a very high perf logging library and this logr is getting used in the Kubernetes project.

I wonder if Gitea really needs to maintain its own logging library.

lunny · 2019-08-25T12:38:51Z

@tamalsaha I don't think Gitea should maintain a logging library itself except no logs could satisfy it's requirements.

tamalsaha · 2019-08-25T12:42:34Z

Is there any issue or doc that explains what are the required features? Or some doc that explains the limitation of other logging libraries?

lunny · 2019-08-25T13:13:44Z

@tamalsaha I think we have no. Only have docs about logging https://docs.gitea.io/zh-cn/logging-configuration/

lunny · 2019-11-15T03:28:33Z

I will close this since it's difficult to rebase the PR.

lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label May 17, 2019

lunny added this to the 1.9.0 milestone May 17, 2019

techknowlogick reviewed May 30, 2019

View reviewed changes

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 30, 2019

techknowlogick changed the title ~~Move code.gitea.io/gitea/modules/log to gitea.com/gitea/log as a standalone package~~ Move code.gitea.io/gitea/modules/log to code.gitea.io/log as a standalone package May 30, 2019

lunny force-pushed the lunny/move_log_dependent_pkg branch 2 times, most recently from 1c7489a to 248a0e2 Compare June 1, 2019 12:35

techknowlogick approved these changes Jun 1, 2019

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 1, 2019

lunny force-pushed the lunny/move_log_dependent_pkg branch from 248a0e2 to 21a6e1a Compare June 1, 2019 15:17

lunny force-pushed the lunny/move_log_dependent_pkg branch 3 times, most recently from d93303a to 64de645 Compare June 22, 2019 07:32

lunny added 11 commits June 23, 2019 09:17

move code.gitea.io/gitea/modules/log to gitea.com/gitea/log as a stan…

80cc4f8

…dalone package

move gitea.com/gitea/log to code.gitea.io/log

a619229

fix lint

34f4215

remove gitlog

db324de

remove gitlog

326cc2e

remove unused files

81b5a28

fix fmt

b93523d

fmt

1f742ee

import order

80a2458

import order

cb38560

fix import

f48ed84

lunny added 3 commits June 23, 2019 09:17

fix import

1efddb3

fix log

5a38395

fix Consistency

8e9b957

lunny force-pushed the lunny/move_log_dependent_pkg branch from 99fac9b to 8e9b957 Compare June 23, 2019 01:17

fix import

a00fec1

lunny modified the milestones: 1.9.0, 1.10.0 Jun 23, 2019

stale bot added the issue/stale label Aug 22, 2019

guillep2k reviewed Aug 22, 2019

View reviewed changes

stale bot removed issue/stale labels Aug 22, 2019

lunny modified the milestones: 1.10.0, 1.11.0 Sep 15, 2019

lunny closed this Nov 15, 2019

lunny deleted the lunny/move_log_dependent_pkg branch November 15, 2019 03:28

lunny removed this from the 1.11.0 milestone Nov 15, 2019

go-gitea locked and limited conversation to collaborators Nov 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move code.gitea.io/gitea/modules/log to code.gitea.io/log as a standalone package #6970

Move code.gitea.io/gitea/modules/log to code.gitea.io/log as a standalone package #6970

lunny commented May 17, 2019 •

edited

Loading

techknowlogick left a comment

techknowlogick May 30, 2019

codecov-io commented Jun 1, 2019 •

edited

Loading

lunny commented Jun 1, 2019

zeripath commented Jun 1, 2019

lunny commented Jun 2, 2019

zeripath commented Jun 2, 2019

stale bot commented Aug 22, 2019

guillep2k Aug 22, 2019

lunny Aug 23, 2019

6543 Nov 4, 2019

6543 Nov 15, 2019

tamalsaha commented Aug 24, 2019

lunny commented Aug 25, 2019

tamalsaha commented Aug 25, 2019

lunny commented Aug 25, 2019

lunny commented Nov 15, 2019

Move code.gitea.io/gitea/modules/log to code.gitea.io/log as a standalone package #6970

Move code.gitea.io/gitea/modules/log to code.gitea.io/log as a standalone package #6970

Conversation

lunny commented May 17, 2019 • edited Loading

techknowlogick left a comment

Choose a reason for hiding this comment

techknowlogick May 30, 2019

Choose a reason for hiding this comment

codecov-io commented Jun 1, 2019 • edited Loading

Codecov Report

lunny commented Jun 1, 2019

zeripath commented Jun 1, 2019

lunny commented Jun 2, 2019

zeripath commented Jun 2, 2019

stale bot commented Aug 22, 2019

guillep2k Aug 22, 2019

Choose a reason for hiding this comment

lunny Aug 23, 2019

Choose a reason for hiding this comment

6543 Nov 4, 2019

Choose a reason for hiding this comment

6543 Nov 15, 2019

Choose a reason for hiding this comment

tamalsaha commented Aug 24, 2019

lunny commented Aug 25, 2019

tamalsaha commented Aug 25, 2019

lunny commented Aug 25, 2019

lunny commented Nov 15, 2019

lunny commented May 17, 2019 •

edited

Loading

codecov-io commented Jun 1, 2019 •

edited

Loading