Support NODE_ENV in webpack

[silverwind]

• Set webpack to development mode when NODE_ENV=development.

[silverwind]

make run added which should resolve the Windows issue.

make did require a special incantation to be able to pass arguments to the executable, so I added that as well, so we can now make run -- --help.

[silverwind]

Simplified so we can now use parallel make jobs to run both targets in parallel:

make build && make -j2 run webpack-dev

Of course, users are free to start gitea however they like and run make webpack-dev separately.

[codecov-io]

Codecov Report

Merging #10245 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10245      +/-   ##
==========================================
- Coverage   43.71%   43.69%   -0.03%     
==========================================
  Files         586      586              
  Lines       81351    81351              
==========================================
- Hits        35565    35547      -18     
- Misses      41389    41404      +15     
- Partials     4397     4400       +3

Impacted Files	Coverage Δ
services/pull/check.go	50% <0%> (-5.49%)	⬇️
modules/git/command.go	86.95% <0%> (-2.61%)	⬇️
services/pull/temp_repo.go	29.05% <0%> (-2.57%)	⬇️
services/pull/patch.go	60.37% <0%> (-2.52%)	⬇️
models/notification.go	63.29% <0%> (-1.9%)	⬇️
modules/indexer/stats/db.go	50% <0%> (ø)	⬆️
modules/git/repo.go	47.7% <0%> (+0.91%)	⬆️
modules/log/event.go	65.64% <0%> (+1.02%)	⬆️
modules/process/manager.go	78.31% <0%> (+3.61%)	⬆️
modules/git/utils.go	70.14% <0%> (+4.47%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad2b913...ad21c4f. Read the comment docs.

[silverwind]

There is a issue with the run argument filtering make -j2 run webpack-dev --port 4000 runs gitea with ./gitea webpack-dev --port 4000 and it seems gitea ignores flags like --port when the command to start is unknown (but the server is still started up, so probably a bug in itself in the args parser). Will check later if that argument filtering mechanism can be fixed.

[silverwind]

Maybe I'll just change it so a simple make webpack-dev does everything including the sub-makes to build and parallel run/watch.

[silverwind]

Marking as WIP for now. I'm still looking for a better solution to start the gitea server in the background for webpack development.

[lafriks]

It would be better to add code to Gitea that would start webpack watch in background with special flag

[silverwind]

@lafriks yes, that would be ideal, but it's probably not within my abilities.

Reduced the changes in this PR so it's not only about adding webpack-dev and a docs update, so I think it is good to go.

[silverwind]

Source maps set on babel-loader as well just in case.

There seems to be an issue with the production source maps (I think browsers may try to retrieve them on the wrong URL) but it's unrelated to this PR and master is also affected.

[lafriks]

@silverwind I created golang package that can be used for this built into Gitea binary: https://github.com/lafriks/go-spaproxy

[silverwind]

@lafriks feel free to take over with another PR. Did you really get hot reloading to work? That'd be even more awesome than --watch which this PR uses.

[lafriks]

Hot reloading will work only for spa apps but would be good if we could at least get watch included in Gitea binary so you would not have run multiple commands

[silverwind]

Yeah, I assume as long as webpack is not in control of HTML, you can not really get hot reloading to work, at least not without major hacks. --watch should be fine for us as a start.

[silverwind]

Removed the Makefile changes, so this PR is now only about supporting NODE_ENV=development which is universally useful.