Skip to content

Conversation

6543
Copy link
Member

@6543 6543 commented Jun 4, 2020

as title

@techknowlogick techknowlogick added the modifies/api This PR adds API routes or modifies them label Jun 4, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Jun 4, 2020
@techknowlogick techknowlogick added the type/enhancement An improvement of existing functionality label Jun 4, 2020
@lafriks
Copy link
Member

lafriks commented Jun 5, 2020

Maybe it would be worth to add more general settings endpoint that would return json with such settings?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 5, 2020
@6543
Copy link
Member Author

6543 commented Jun 5, 2020

@lafriks you mean GeneralRepoSettings or something like this?

@lafriks
Copy link
Member

lafriks commented Jun 5, 2020

yeah, for example GET /api/v1/settings/repository that would retrun JSON:

{
  "mirrorsEnabled": false
}

@6543 6543 changed the title API expose MirrorsDisabled setting API expose MirrorsDisabled,HTTPGitDisabled,MaxCreationLimit settings Jun 8, 2020
@6543 6543 changed the title API expose MirrorsDisabled,HTTPGitDisabled,MaxCreationLimit settings API expose usefull General Repo settings settings Jun 8, 2020
@6543 6543 force-pushed the api_expose-setting-MirrorsDisabled branch from 8bb6f71 to 81005c8 Compare June 8, 2020 13:02
@6543
Copy link
Member Author

6543 commented Jun 8, 2020

@lafriks how do you like this?

Co-authored-by: proton <25139420+proton-ab@users.noreply.github.com>
@6543
Copy link
Member Author

6543 commented Jun 9, 2020

@proton-ab thx - do you have suggestions for other repo related instance settings witch are usefull to expose?

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 9, 2020
@lafriks
Copy link
Member

lafriks commented Jun 9, 2020

@6543 imho looks good :)

@6543
Copy link
Member Author

6543 commented Jun 9, 2020

@mrsdizzie will do a pull witch create a new section in swagger docs & move allowed_reactions - throu its outside of this pull scope :)

@mrsdizzie
Copy link
Member

Sounds good!

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 9, 2020
@lafriks
Copy link
Member

lafriks commented Jun 10, 2020

🚀

@lafriks lafriks merged commit 68a2af6 into go-gitea:master Jun 10, 2020
@lafriks lafriks deleted the api_expose-setting-MirrorsDisabled branch June 10, 2020 12:05
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
* GeneralRepoSettings expose MirrorsDisabled, HTTPGitDisabled, MaxCreationLimit

* Apply suggestions from code review

Co-authored-by: proton <25139420+proton-ab@users.noreply.github.com>

* lint

Co-authored-by: proton <25139420+proton-ab@users.noreply.github.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants