Auto-init repo on license, .gitignore select #12202
Conversation
GiteaBot
added
the
lgtm/need 2
|
Please don't use globals like that. You can check for the new repo page like this and run your code if the selector matches: if (document.querySelector('.repository.new.repo')) {
// your code here
} |
When a .gitignore or LICENSE file is added, the user is expecting the repository to be auto-initialized. However, nothing sets the auto_init value, so it remains at its default. We should set it to checked when a .gitignore or LICENSE file is added, matching user expectations. If the user clears .gitignore or LICENSE, it will leave repository creation enabled. If the user changes the value again, it will re-check the box if the user has since de-checked it. This behavior is at least consistent. Resolves: go-gitea#11071 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy
force-pushed
the
detect-auto-init-repository
branch
from
9419339
to
63a0256
Compare
Ah gotcha. Probably should migrate the old globals to the newer style sometime... @silverwind Thanks! Updated. Hopefully the jquery style is to your liking. :) |
Co-authored-by: silverwind <me@silverwind.io>
|
Sorry, was out of internet range. Updated! |
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: Lauris BH <lauris@nix.lv>
|
Lint complains about ident |
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/done
| const gitignores = $('input[name="gitignores"]').prop('checked'); | ||
| const license = $('input[name="license"]').prop('checked'); |
There was a problem hiding this comment.
I just realized that these are not checkboxes :D These lines should have been:
const gitignores = $('input[name="gitignores"]').val() !== '';
const license = $('input[name="license"]').val() !== '';
There was a problem hiding this comment.
Right I missed it too. .val() should be sufficient and possible more future-proof just in case the value of a empty select box ever changes to null or undefined.
There was a problem hiding this comment.
Thanks for PR. I don't think jQuery would return null or undefined but not sure. Have not used jQuery for quite some time already 😂
There was a problem hiding this comment.
Nothing to do with jQuery, but I guess DOM <input> value is probably guaranteed to be a string (even for type=number 😆).
|
I don't know how I messed up that, sorry :) |
When a
.gitignoreorLICENSEfile is added, the user is expecting therepository to be auto-initialized. However, nothing sets the
auto_initvalue, so it remains at its default. We should set it to checked when
a
.gitignoreorLICENSEfile is added, matching user expectations. Ifthe user clears
.gitignoreorLICENSE, it will leave repository creationenabled. If the user changes the value again, it will re-check the box
if the user has since de-checked it. This behavior is at least
consistent.
Resolves: #11071
Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>