Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

license does not automatically initialise repository #11071

Closed
3 of 9 tasks
marvinjuette opened this issue Apr 14, 2020 · 3 comments · Fixed by #12202
Closed
3 of 9 tasks

license does not automatically initialise repository #11071

marvinjuette opened this issue Apr 14, 2020 · 3 comments · Fixed by #12202
Labels
topic/ui Change the appearance of the Gitea UI
Milestone
1.13.0

Comments

@marvinjuette
Copy link

marvinjuette commented Apr 14, 2020 •
edited
Loading

  • Gitea version (or commit ref):1.11.4
  • Git version: 2.20.1
  • Operating system: Raspbian Buster
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

After selecting .gitignore presets or a license preset the checkbox will not automatically be activated.

actual behaviour:

  • Initialize Repository (Adds .gitignore, License and README)

expected behaviour:

  • Initialize Repository (Adds .gitignore, License and README)
    😉
    ...

Screenshots

image
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Apr 15, 2020
@stale
Copy link

stale bot commented Jun 14, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Jun 14, 2020
@stale
Copy link

stale bot commented Jun 28, 2020

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this as completed Jun 28, 2020
@marvinjuette
Copy link
Author

Still not working ...

@lafriks lafriks reopened this Jun 28, 2020
@stale stale bot removed the issue/stale label Jun 28, 2020
@cipherboy cipherboy mentioned this issue Jul 9, 2020
Merged
cipherboy added a commit to cipherboy/gitea that referenced this issue Jul 9, 2020
@cipherboy
Auto-init repo on license, .gitignore select
63a0256 
When a .gitignore or LICENSE file is added, the user is expecting the
repository to be auto-initialized. However, nothing sets the auto_init
value, so it remains at its default. We should set it to checked when
a .gitignore or LICENSE file is added, matching user expectations. If
the user clears .gitignore or LICENSE, it will leave repository creation
enabled. If the user changes the value again, it will re-check the box
if the user has since de-checked it. This behavior is at least
consistent.

Resolves: go-gitea#11071

Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
lafriks added a commit that referenced this issue Jul 23, 2020
@cipherboy @silverwind @lafriks
Auto-init repo on license, .gitignore select (#12202)
4497db9 
* Auto-init repo on license, .gitignore select

When a .gitignore or LICENSE file is added, the user is expecting the
repository to be auto-initialized. However, nothing sets the auto_init
value, so it remains at its default. We should set it to checked when
a .gitignore or LICENSE file is added, matching user expectations. If
the user clears .gitignore or LICENSE, it will leave repository creation
enabled. If the user changes the value again, it will re-check the box
if the user has since de-checked it. This behavior is at least
consistent.

Resolves: #11071

Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Lauris BH <lauris@nix.lv>
@lafriks lafriks added this to the 1.13.0 milestone Jul 23, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.13.0
Development

Successfully merging a pull request may close this issue.

Auto-init repo on license, .gitignore select cipherboy/gitea
2 participants
@lafriks @marvinjuette