Improve HTML escaping helper #12383
Merged
Improve HTML escaping helper #12383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
changed the title
zeripath
approved these changes
Jul 30, 2020
GiteaBot
added
the
lgtm/need 1
|
I initially wanted to use https://github.com/sindresorhus/escape-goat but that module got some bloat recently so I decided to just copy the function from there. Not like this will ever change. |
mrsdizzie
approved these changes
Jul 30, 2020
GiteaBot
added
lgtm/done
The previous method did not escape single quotes which under some circumstances can lead to XSS vulnerabilites and the fact that it depends on jQuery is also not ideal. Replace it with a lightweight module.
|
Switched to the module again. With webpack's tree-shaking the unused parts will not be included in the output. The tagged template versions may also be useful at some point. |
|
🚀 |
|
I don't think this will need a backport. There's probably no XSS possible in the existing usage, so this is more of a refactor. |
|
Do we think this needs backporting? |
|
While I don't think it's really necessary, we can do it of course just to be safe from theoretical single-quote issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous method did not escape single quotes which under some circumstances can lead to XSS vulnerabilites and the fact that it depends on jQuery is also not ideal. Replace it with a lightweight module.