Apply #12576 to top right reaction picker

[CL-Jeremy]

I'll just open this since I cannot find a reason for the bug below.

After this PR, the reaction emoji is slightly shifted toward right in the top right drop-down. Seeing this in both Chromium (81) and Safari, but not in Firefox. Bottom left picker is unaffected.

Edit: confirmed to be Apple-specific. Should have something to do with the rendering engine.

[codecov-commenter]

Codecov Report

Merging #12623 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #12623   +/-   ##
=======================================
  Coverage   43.44%   43.44%           
=======================================
  Files         645      645           
  Lines       71328    71328           
=======================================
+ Hits        30986    30989    +3     
+ Misses      35331    35328    -3     
  Partials     5011     5011           

Impacted Files	Coverage Δ
models/unit.go	46.57% <0.00%> (-2.74%)	⬇️
modules/process/manager.go	72.50% <0.00%> (-2.50%)	⬇️
services/pull/pull.go	41.57% <0.00%> (-0.47%)	⬇️
modules/queue/workerpool.go	60.00% <0.00%> (+1.22%)	⬆️
modules/queue/unique_queue_disk_channel.go	55.38% <0.00%> (+1.53%)	⬆️
modules/log/event.go	59.43% <0.00%> (+1.88%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bf1c4f...51a3a53. Read the comment docs.

[lafriks]

how does it look in dark theme?

[CL-Jeremy]

In Arc Green theme the only change is the rule for overriding highlight color on hover. The two popups would match exactly except for the bug I mentioned earlier.

Edit: more screenshots under macOS Catalina. Microsoft Edge shifts the emoji ever so slightly to the right, Safari to the left.

[silverwind]

I'm not sure what this change exactly fixes from the screenshots. Can you showcase a before/after comparison?

Last time I worked at that picker, I had the idea of rewriting it to flexbox because it's quite a hack currently, layout-wise.

[CL-Jeremy]

As the title suggests, this PR adds hover effect to the picker in the top right corner.

For comparison, goto try.gitea.io and click on any of the top right picker icons.

The previous :hover styling targeted .select-reaction .item in .segment.reactions only, leaving out the top ones.

[silverwind]

Ah I see. Totally missed the fact that there's two ways to trigger that menu.