Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix size and clickable area on file table back link #13205

Merged
merged 1 commit into from
Oct 18, 2020

Conversation

silverwind
Copy link
Member

Fixes: #13038

Should backport to 1.13.

image

@codecov-io
Copy link

Codecov Report

Merging #13205 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13205      +/-   ##
==========================================
+ Coverage   42.01%   42.02%   +0.01%     
==========================================
  Files         683      683              
  Lines       75215    75215              
==========================================
+ Hits        31598    31607       +9     
+ Misses      38451    38444       -7     
+ Partials     5166     5164       -2     
Impacted Files Coverage Δ
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
services/pull/pull.go 41.27% <0.00%> (+0.49%) ⬆️
models/repo_list.go 79.46% <0.00%> (+0.89%) ⬆️
services/pull/patch.go 54.54% <0.00%> (+1.70%) ⬆️
services/pull/temp_repo.go 29.78% <0.00%> (+3.19%) ⬆️
services/pull/check.go 52.55% <0.00%> (+3.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4077993...fe7fa87. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 18, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 18, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 18, 2020
@lafriks lafriks added type/bug topic/ui Change the appearance of the Gitea UI labels Oct 18, 2020
@lafriks lafriks added this to the 1.13.0 milestone Oct 18, 2020
@lafriks lafriks modified the milestones: 1.13.0, 1.14.0 Oct 18, 2020
@lafriks lafriks merged commit 06eaf74 into go-gitea:master Oct 18, 2020
@lafriks
Copy link
Member

lafriks commented Oct 18, 2020

Please send backport

techknowlogick pushed a commit to techknowlogick/gitea that referenced this pull request Oct 19, 2020
@techknowlogick
Copy link
Member

Backport at #13207

lafriks pushed a commit that referenced this pull request Oct 19, 2020
Fixes: #13038

Should backport to 1.13.

Co-authored-by: silverwind <me@silverwind.io>
@lafriks lafriks added the backport/done All backports for this PR have been created label Oct 19, 2020
@silverwind silverwind deleted the backlink branch October 19, 2020 07:00
ivanvc added a commit to ivanvc/gitea that referenced this pull request Oct 21, 2020
…ments-in-pull-request-label-style

* origin/master: (27 commits)
  [skip ci] Updated translations via Crowdin
  add more clarification to the issue-template.md (go-gitea#13235)
  go-version constraints ignore pre-releases (go-gitea#13234)
  [skip ci] Updated translations via Crowdin
  Update some JS dependencies (go-gitea#13222)
  Return the full rejection message and errors in flash errors (go-gitea#13221)
  Update heatmap fixtures to restore tests (go-gitea#13224)
  [skip ci] Updated translations via Crowdin
  Add review request api (go-gitea#11355)
  [skip ci] Updated translations via Crowdin
  When the git ref is unable to be found return broken pr (go-gitea#13218)
  Various arc-green fixes (go-gitea#13214)
  Show stale label for stale code comment which is marked as resolved (go-gitea#13213)
  Move install pages out of main macaron routes (go-gitea#13195)
  Use CSS Variables for fonts, remove postcss-loader (go-gitea#13204)
  [skip ci] Updated translations via Crowdin
  Align `SSH_AUTHORIZED_KEYS_BACKUP` var with the value in `app.ini` (go-gitea#13212)
  Fix size and clickable area on file table back link (go-gitea#13205)
  [skip ci] Updated translations via Crowdin
  Fix error in diff html rendering (go-gitea#13191)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clickable area on files table links seems to have shrinked
6 participants