Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clickable area on files table links seems to have shrinked #13038

Closed
2 tasks done
wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf opened this issue Oct 5, 2020 · 1 comment · Fixed by #13205
Closed
2 tasks done

Clickable area on files table links seems to have shrinked #13038

wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf opened this issue Oct 5, 2020 · 1 comment · Fixed by #13205
Labels
type/bug
Milestone
1.13.0

Comments

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor

Description

As discussed in discord with @jolheiser (etzelia/rooibos).

At the moment, try.gitea.io is running the same Gitea version as my instance, so I am also (as of now) able to "replicate" it there.

The #12553 was supposed to increase clickable link area, but, unfortunately, seems to have stopped working in the meanwhile.

When pointing the cursor even a little off a link's text, it's not possible to click the link anymore, so there's been a regression apparently since the subject PR.

One especially curious example is the "go to a parent folder" (see screenshot) case, where one is forced to point the cursor at a really small .. area or the link is not active.

This is not in fact a new issue to me, I just recently got to asking about it, so chances are a possible regression was introduced - if memory serves - up to a month ago, so that is possibly fairly recently after the improvement has been introduced.

Screenshots

image
@lunny lunny added the type/bug label Oct 6, 2020
@silverwind
Copy link
Member

silverwind commented Oct 7, 2020 •
edited
Loading

#12617 is the latest iteration of this. It had to be reverted from the initial full-width area to just a vertical enlargement because I was not able to get the text ellipsis to properly work with a fully streched <a>, it's a very tricky issue.

Parent link seems like a bug, it should be at least as high as the other rows and can possibly be made full-width.

silverwind added a commit to silverwind/gitea that referenced this issue Oct 18, 2020
@silverwind
Fix size and clickable area on file table back link
fe7fa87 
Fixes: go-gitea#13038

Should backport to 1.13.
@silverwind silverwind mentioned this issue Oct 18, 2020
Merged
lafriks pushed a commit that referenced this issue Oct 18, 2020
@silverwind
Fix size and clickable area on file table back link (#13205)
06eaf74 
Fixes: #13038

Should backport to 1.13.
techknowlogick pushed a commit to techknowlogick/gitea that referenced this issue Oct 19, 2020
@silverwind @techknowlogick
Fix size and clickable area on file table back link (go-gitea#13205)
755eaff 
Fixes: go-gitea#13038

Should backport to 1.13.
@techknowlogick techknowlogick mentioned this issue Oct 19, 2020
Merged
lafriks pushed a commit that referenced this issue Oct 19, 2020
@techknowlogick @silverwind
Fix size and clickable area on file table back link (#13205) (#13207)
e97466b 
Fixes: #13038

Should backport to 1.13.

Co-authored-by: silverwind <me@silverwind.io>
@lafriks lafriks added this to the 1.13.0 milestone Oct 19, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging a pull request may close this issue.

Fix size and clickable area on file table back link silverwind/gitea
4 participants
@lunny @silverwind @lafriks @wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf