Migration not fail on notmigrated reactions #13507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
added
type/bug
skip-changelog
zeripath
approved these changes
Nov 10, 2020
GiteaBot
added
the
lgtm/need 1
|
It would be helpful to do the checks at the gitea_uploader code too I think |
|
@zeripath GitHub & Gitlab dont have this issue ... but the uploader should check it's data in generell ... this looks to me like there has to be done some enhancement and refactoring |
a1012112796
approved these changes
Nov 11, 2020
GiteaBot
added
lgtm/done
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13505 provides a fix for #13271 for 1.14 however, this cannot be backported to 1.13 as it is reliant on a db migration to extend the constraint. This PR provides alternate fix - dropping reactions that would cause the problem.