Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user filter to issueTrackedTimes, enable usage for issue managers #14081

Merged
merged 8 commits into from
Dec 22, 2020
Merged

Add user filter to issueTrackedTimes, enable usage for issue managers #14081

merged 8 commits into from
Dec 22, 2020

Conversation

noerw
Copy link
Member

@noerw noerw commented Dec 20, 2020 •
edited
Loading

fixes #14024
fixes #13414

@noerw noerw requested a review from 6543 December 20, 2020 23:56
@noerw noerw added modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality labels Dec 20, 2020
@codecov-io
Copy link

codecov-io commented Dec 21, 2020 •
edited
Loading

Codecov Report

Merging #14081 (a75ed37) into master (addd424) will decrease coverage by 0.02%.
The diff coverage is 15.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14081      +/-   ##
==========================================
- Coverage   42.34%   42.32%   -0.03%     
==========================================
  Files         726      726              
  Lines       77741    77759      +18     
==========================================
- Hits        32918    32908      -10     
- Misses      39421    39444      +23     
- Partials     5402     5407       +5
Impacted Files Coverage Δ
routers/api/v1/repo/issue_tracked_time.go 20.00% <15.38%> (+0.20%) ⬆️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.54%) ⬇️
modules/queue/workerpool.go 57.95% <0.00%> (-0.82%) ⬇️
models/gpg_key.go 53.33% <0.00%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update addd424...a75ed37. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 21, 2020
@6543 6543 added this to the 1.14.0 milestone Dec 21, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 21, 2020
@noerw noerw changed the title add user filter to issueTrackedTimes Add user filter to issueTrackedTimes, enable usage for issue managers Dec 21, 2020
@noerw noerw mentioned this pull request Dec 21, 2020
Closed
1 task
6543
6543 requested changes Dec 21, 2020
View reviewed changes
routers/api/v1/repo/issue_tracked_time.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 21, 2020
@6543
Copy link
Member

6543 commented Dec 22, 2020

🚀

@6543 6543 merged commit c2ae432 into go-gitea:master Dec 22, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.14.0
5 participants
@noerw @codecov-io @6543 @lunny @GiteaBot