Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed invalid form tag introduced by #5073. #14391

Merged
merged 4 commits into from
Jan 19, 2021
Merged

Removed invalid form tag introduced by #5073. #14391

merged 4 commits into from
Jan 19, 2021

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Jan 18, 2021

Removed invalid form tag introduced by #5073.

@6543 6543 added this to the 1.14.0 milestone Jan 18, 2021
@6543 6543 added the type/bug label Jan 18, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 18, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 19, 2021
@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 19, 2021
@codecov-io
Copy link

Codecov Report

Merging #14391 (7b4aa25) into master (b59ed41) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14391      +/-   ##
==========================================
- Coverage   41.86%   41.83%   -0.03%     
==========================================
  Files         744      744              
  Lines       79746    79746              
==========================================
- Hits        33383    33360      -23     
- Misses      40853    40871      +18     
- Partials     5510     5515       +5
Impacted Files Coverage Δ
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/git/tree_entry_nogogit.go 87.50% <0.00%> (-6.25%) ⬇️
modules/charset/charset.go 68.53% <0.00%> (-2.25%) ⬇️
services/gitdiff/gitdiff.go 68.99% <0.00%> (-1.94%) ⬇️
modules/log/file.go 73.60% <0.00%> (-1.61%) ⬇️
models/repo_list.go 77.87% <0.00%> (-0.89%) ⬇️
services/pull/pull.go 42.15% <0.00%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 185c5ae...7d9c234. Read the comment docs.

@6543 6543 merged commit 8d0e331 into go-gitea:master Jan 19, 2021
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Jan 19, 2021
@KN4CK3R @6543
Removed invalid form tag (go-gitea#14391)
dbb1040 
introduced by go-gitea#5073
@6543 6543 mentioned this pull request Jan 19, 2021
Merged
@6543 6543 added the backport/done All backports for this PR have been created label Jan 19, 2021
lafriks pushed a commit that referenced this pull request Jan 19, 2021
@6543 @KN4CK3R
Removed invalid form tag (#14391) (#14395)
4583caa 
introduced by #5073

Co-authored-by: KN4CK3R <KN4CK3R@users.noreply.github.com>
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 19, 2021
@a1012112796
Merge branch 'master' into imap
f076123 
* master:
  Add pager to the branches page (go-gitea#14202)
  Removed invalid form tag (go-gitea#14391)
  Update back-up restore example for 1.13 changes (go-gitea#14374)
  It seems vet on windows is unnecessary (go-gitea#14302)
@KN4CK3R KN4CK3R deleted the fix-form branch January 19, 2021 07:33
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
6 participants
@KN4CK3R @codecov-io @6543 @a1012112796 @techknowlogick @GiteaBot