[API] Add issue and comment attachments #14601

andrebruch · 2021-02-07T18:07:12Z

The following API routes have been added:

Issues

GET /repos/{owner}/{repo}/issues/assets/{attachment_id}
GET /repos/{owner}/{repo}/issues/{index}/assets
POST /repos/{owner}/{repo}/issues/{index}/assets
PATCH /repos/{owner}/{repo}/issues/assets/{attachment_id}
DELETE /repos/{owner}/{repo}/issues/assets/{attachment_id}

Comments

GET /repos/{owner}/{repo}/issues/comments/assets/{attachment_id}
GET /repos/{owner}/{repo}/issues/comments/{id}/assets
POST /repos/{owner}/{repo}/issues/comments/{id}/assets
PATCH /repos/{owner}/{repo}/issues/comments/assets/{attachment_id}
DELETE /repos/{owner}/{repo}/issues/comments/assets/{attachment_id}

close #3690

zeripath · 2021-02-07T22:39:41Z

Please run make generate-swagger and commit the changes

modules/convert/issue.go

modules/convert/issue_comment.go

zeripath · 2021-02-07T22:52:49Z

routers/api/v1/repo/issue_attachment.go

+	}
+
+	if attach.IssueID == 0 {
+		log.Info("User requested attachment is not in issue, attachment_id: %v", attachID)


Hmm not sure about this logging level. I suspect it's too high but I can see you don't want people to crawl it...

andrebruch · 2021-02-08T23:02:30Z

Please run make generate-swagger and commit the changes

The swagger spec is already there.

jolheiser · 2021-02-08T23:26:01Z

Currently the linter is mad because it's detecting duplicate code.
https://drone.gitea.io/go-gitea/gitea/35748/1/4

andrebruch · 2021-02-09T22:55:10Z

The code is quite similar, but not the same.

lunny · 2021-03-03T11:51:59Z

routers/api/v1/repo/issue_attachment.go

@@ -5,6 +5,7 @@
 package repo

 import (
+	issue_service "code.gitea.io/gitea/services/issue"


import order.

lunny · 2021-03-03T11:52:54Z

routers/repo/issue.go

@@ -1673,17 +1673,17 @@ func UpdateIssueContent(ctx *context.Context) {
 		return
 	}

+	files := ctx.QueryStrings("files[]")
+	if err := updateAttachments(issue, files); err != nil {
+		ctx.ServerError("UpdateAttachments", err)


return missed

andrebruch · 2021-03-13T02:50:28Z

It looks like a new line in the v1_json.tmpl file solved the duplicate code and make generate-swagger issues.

The make generate-swagger and make swagger-check commands remove the last line in the v1_json.tmpl file on my system.

andrebruch · 2021-03-13T04:09:36Z

The following test fails:
testing-amd64 > test-mssql > TestGit/HTTP/MergeFork/CreatePRAndMerge

I just run the tests locally on a MSSQL database and there were no problems.

6543 · 2021-04-15T20:40:39Z

@andrebruch would be nice if you could resolve conflicts and adopt related changes :)

mattrpav · 2022-04-21T17:12:41Z

Checking in-- how's this looking for inclusion with a 1.17.0 or a 1.16.x release?

6543 · 2022-04-21T17:14:01Z

1.17.0 ...

6543 · 2022-04-21T17:14:27Z

... I can have a look at finishing it - next week?!?

modules/context/api.go

lunny

Please follow my comments.

lunny · 2022-05-09T13:19:22Z

routers/api/v1/repo/issue_comment_attachment.go

+}
+
+func canUserWriteIssueCommentAttachment(ctx *context.APIContext, c *models.Comment) (success bool) {
+	canEditComment := ctx.Doer.ID == c.PosterID || ctx.IsUserRepoAdmin() || ctx.IsUserSiteAdmin()


We should check if user has a write permission to the issue.

mattrpav · 2022-07-13T16:06:12Z

Friendly comment to bubble up. Thanks all!

mattrpav · 2022-10-12T13:45:11Z

Hi @6543 @lunny checking in. Any update to the plans for this feature request?

lunny · 2022-10-12T14:03:54Z

The review comments should be followed and conflict files should be resolved.

6543 · 2022-10-19T19:02:26Z

original contributor is not responding so everybody looking at this pull and want it ...

if you have time, checkout to the pull-head and create a new branch on you own fork and submit a pull ... then fix all open mentioned issues and we will merge that one :)

mattrpav · 2022-11-11T21:23:48Z

Hi @6543 @lunny @andrebruch - Thanks for the follow-ups. I'm not a Go programmer, so I don't think anyone wants to see me tackle the patch at this point ;-). Is there a tip jar or other option to financially back this feature?

I have committed to writing a JIRA-to-Gitea migration tool and publish blog for others to benefit-- and we are happy to kick in money for a Gitea/Go programmer to finish out this PR.

Also, this feature will be needed by any organization that wants to use Gitea and maintain automated security compliance (SOC2, ISO27001, etc).

Thanks!

lunny · 2022-11-12T00:19:39Z

Hi @6543 @lunny @andrebruch - Thanks for the follow-ups. I'm not a Go programmer, so I don't think anyone wants to see me tackle the patch at this point ;-). Is there a tip jar or other option to financially back this feature?

I have committed to writing a JIRA-to-Gitea migration tool and publish blog for others to benefit-- and we are happy to kick in money for a Gitea/Go programmer to finish out this PR.

Also, this feature will be needed by any organization that wants to use Gitea and maintain automated security compliance (SOC2, ISO27001, etc).

Thanks!

Thank you very much! You can contribute in bountysource for #3690 but even that I cannot guarantee this could be resolved in a short days.

mattrpav · 2022-11-12T01:42:24Z

@lunny This looks like the Bountysource link for #3690 and I contributed $100 (USD).

How much $ do you think to have it completed by December 31st?

lunny · 2022-11-14T07:42:42Z

Let's continue in #21783

Close #14601 Fix #3690 Revive of #14601. Updated to current code, cleanup and added more read/write checks. Signed-off-by: Andrew Thornton <art27@cantab.net> Signed-off-by: Andre Bruch <ab@andrebruch.com> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: Norwin <git@nroo.de> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

[API] Add issue and comment attachments

f9595c3

This was referenced Feb 7, 2021

Issue API and Attachments #3690

Closed

[Feature] [API] get/post/delete issue/pull/comment attachments #12520

Closed

6543 added modifies/api This PR adds API routes or modifies them type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Feb 7, 2021

6543 added this to the 1.15.0 milestone Feb 7, 2021

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 7, 2021

zeripath reviewed Feb 7, 2021

View reviewed changes

modules/convert/issue.go Outdated Show resolved Hide resolved

zeripath reviewed Feb 7, 2021

View reviewed changes

modules/convert/issue_comment.go Outdated Show resolved Hide resolved

zeripath reviewed Feb 7, 2021

View reviewed changes

Specify capacity for assets slice

04abe85

andrebruch added 3 commits March 2, 2021 22:54

Make comment attachments accessible

bef0c92

Update attachments in correct order

10d7f90

Fix: Notifications for API attachments

806143c

lunny reviewed Mar 3, 2021

View reviewed changes

andrebruch added 2 commits March 13, 2021 02:27

Fix: new line in v1_json.tmpl

dc49872

Fix import order

7393e67

andrebruch closed this Mar 13, 2021

andrebruch force-pushed the feature-add-issue-and-comment-attachments-api branch from 29e9315 to 240fea8 Compare March 13, 2021 01:58

andrebruch reopened this Mar 13, 2021

Fix missed return

488a072

Merge branch 'master' into feature-add-issue-and-comment-attachments-api

7ac28eb

lunny reviewed Apr 22, 2022

View reviewed changes

modules/context/api.go Outdated Show resolved Hide resolved

lunny requested changes Apr 22, 2022

View reviewed changes

6543 added 4 commits April 22, 2022 20:40

Merge branch 'master' into feature-add-issue-and-comment-attachments-api

e39c3de

adapt latest refactors

fbab446

rm merge conflict resolve

c8cafc0

format & fix

5bd533c

6543 force-pushed the feature-add-issue-and-comment-attachments-api branch from 87fd2df to 5bd533c Compare April 22, 2022 18:57

6543 mentioned this pull request Apr 28, 2022

Issue Attachments do not migrate on Gitea to Gitea migration #17863

Open

lunny reviewed May 9, 2022

View reviewed changes

lunny modified the milestones: 1.17.0, 1.18.0 May 25, 2022

lunny modified the milestones: 1.18.0, 1.19.0 Oct 17, 2022

KN4CK3R mentioned this pull request Nov 12, 2022

Add API management for issue/pull and comment attachments #21783

Merged

lunny closed this Nov 14, 2022

lunny removed this from the 1.19.0 milestone Nov 14, 2022

go-gitea locked and limited conversation to collaborators May 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[API] Add issue and comment attachments #14601

[API] Add issue and comment attachments #14601

andrebruch commented Feb 7, 2021 •

edited by 6543

zeripath commented Feb 7, 2021

zeripath Feb 7, 2021

andrebruch commented Feb 8, 2021

jolheiser commented Feb 8, 2021

andrebruch commented Feb 9, 2021

lunny Mar 3, 2021

lunny Mar 3, 2021

andrebruch commented Mar 13, 2021

andrebruch commented Mar 13, 2021

6543 commented Apr 15, 2021

mattrpav commented Apr 21, 2022

6543 commented Apr 21, 2022

6543 commented Apr 21, 2022 •

edited

lunny left a comment

lunny May 9, 2022

mattrpav commented Jul 13, 2022

mattrpav commented Oct 12, 2022

lunny commented Oct 12, 2022

6543 commented Oct 19, 2022 •

edited

mattrpav commented Nov 11, 2022

lunny commented Nov 12, 2022

mattrpav commented Nov 12, 2022 •

edited

lunny commented Nov 14, 2022

[API] Add issue and comment attachments #14601

[API] Add issue and comment attachments #14601

Conversation

andrebruch commented Feb 7, 2021 • edited by 6543

zeripath commented Feb 7, 2021

zeripath Feb 7, 2021

Choose a reason for hiding this comment

andrebruch commented Feb 8, 2021

jolheiser commented Feb 8, 2021

andrebruch commented Feb 9, 2021

lunny Mar 3, 2021

Choose a reason for hiding this comment

lunny Mar 3, 2021

Choose a reason for hiding this comment

andrebruch commented Mar 13, 2021

andrebruch commented Mar 13, 2021

6543 commented Apr 15, 2021

mattrpav commented Apr 21, 2022

6543 commented Apr 21, 2022

6543 commented Apr 21, 2022 • edited

lunny left a comment

Choose a reason for hiding this comment

lunny May 9, 2022

Choose a reason for hiding this comment

mattrpav commented Jul 13, 2022

mattrpav commented Oct 12, 2022

lunny commented Oct 12, 2022

6543 commented Oct 19, 2022 • edited

mattrpav commented Nov 11, 2022

lunny commented Nov 12, 2022

mattrpav commented Nov 12, 2022 • edited

lunny commented Nov 14, 2022

andrebruch commented Feb 7, 2021 •

edited by 6543

6543 commented Apr 21, 2022 •

edited

6543 commented Oct 19, 2022 •

edited

mattrpav commented Nov 12, 2022 •

edited