Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Add issue and comment attachments #14601

Closed
wants to merge 44 commits into from
Closed

[API] Add issue and comment attachments #14601

wants to merge 44 commits into from

Commits on Feb 7, 2021

  1. [API] Add issue and comment attachments

    @andrebruch
    andrebruch committed Feb 7, 2021
    Configuration menu
    Copy the full SHA
    f9595c3 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. Specify capacity for assets slice

    @andrebruch
    andrebruch committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    04abe85 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2021

  1. Make comment attachments accessible

    @andrebruch
    andrebruch committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    bef0c92 View commit details
    Browse the repository at this point in the history

  2. Update attachments in correct order

    @andrebruch
    andrebruch committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    10d7f90 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. Fix: Notifications for API attachments

    @andrebruch
    andrebruch committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    806143c View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2021

  1. Fix: new line in v1_json.tmpl

    @andrebruch
    andrebruch committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    dc49872 View commit details
    Browse the repository at this point in the history

  2. Fix import order

    @andrebruch
    andrebruch committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    7393e67 View commit details
    Browse the repository at this point in the history

  3. Fix missed return

    @andrebruch
    andrebruch committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    488a072 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into feature-add-issue-and-comment-attachments-api

    @zeripath
    zeripath committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    7ac28eb View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2021

  1. Merge remote-tracking branch 'origin/main' into feature-add-issue-and… 

    …-comment-attachments-api
    @zeripath
    zeripath committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    6e3cf41 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2021

  1. Merge branch 'main' into feature-add-issue-and-comment-attachments-api

    @6543
    6543 committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    7dff40d View commit details
    Browse the repository at this point in the history

  2. partial correction of permissions checks 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    75785e1 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2021

  1. Fix title of error 

    Co-authored-by: Norwin <noerw@users.noreply.github.com>
    @andrebruch @noerw
    andrebruch and noerw committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    202ece1 View commit details
    Browse the repository at this point in the history

  2. Merge functions ToIssueAttachment and ToCommentAttachment

    @andrebruch
    andrebruch committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    587605e View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2021

  1. deduplicate convert.ToAttachment()

    @noerw @6543
    noerw authored and 6543 committed Oct 3, 2021
    Configuration menu
    Copy the full SHA
    036dd17 View commit details
    Browse the repository at this point in the history

  2. refer to issue by index, not by ID..

    @noerw @6543
    noerw authored and 6543 committed Oct 3, 2021
    Configuration menu
    Copy the full SHA
    9c433e5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feature-add-issue-and-comment-attachments-api

    @6543
    6543 committed Oct 3, 2021
    Configuration menu
    Copy the full SHA
    065d88f View commit details
    Browse the repository at this point in the history

  4. use attachment_service.UploadAttachment() 

    DRY, but need to refactor to specify comment + issue ID
    @noerw @6543
    noerw authored and 6543 committed Oct 3, 2021
    Configuration menu
    Copy the full SHA
    d883f69 View commit details
    Browse the repository at this point in the history

  5. fix permissions of *IssueAttachment()

    @noerw @6543
    noerw authored and 6543 committed Oct 3, 2021
    Configuration menu
    Copy the full SHA
    e98bf3e View commit details
    Browse the repository at this point in the history

  6. WIP: fix permissions of *IssueCommentAttachment()

    @noerw @6543
    noerw authored and 6543 committed Oct 3, 2021
    Configuration menu
    Copy the full SHA
    f2a05e7 View commit details
    Browse the repository at this point in the history

  7. rm dublicate func

    @6543
    6543 committed Oct 3, 2021
    Configuration menu
    Copy the full SHA
    ad9a947 View commit details
    Browse the repository at this point in the history

  8. update swagger

    @6543
    6543 committed Oct 3, 2021
    Configuration menu
    Copy the full SHA
    f99ee82 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. fixup! fix permissions of *IssueAttachment()

    @noerw
    noerw committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    5134ff6 View commit details
    Browse the repository at this point in the history

  2. fix permissions of *IssueCommentAttachment() (cont)

    @noerw
    noerw committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    7557df1 View commit details
    Browse the repository at this point in the history

  3. move all asset APIs into issue / comment namespace

    @noerw
    noerw committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    170134a View commit details
    Browse the repository at this point in the history

  4. fix swagger docs

    @noerw
    noerw committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    a776dc2 View commit details
    Browse the repository at this point in the history

  5. fix updating issue

    @noerw
    noerw committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    bfafd9d View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into feature-add-issue-and-comment-attachments-api

    @6543
    6543 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    ed6d55e View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2021

  1. Correct the year of the code contribution

    @andrebruch
    andrebruch committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    6b521f2 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2021

  1. Merge branch 'main' into feature-add-issue-and-comment-attachments-api

    @6543
    6543 committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    e5633d8 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2021

  1. fix errors 

    always return json, always return message, DRY refactor
    @noerw @andrebruch
    noerw authored and andrebruch committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    32e8508 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. Fix call of GetIssueByIndex and correction of grammar errors

    @andrebruch
    andrebruch committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    d32924d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature-add-issue-and-comment-attachments-api 

    # Conflicts:
#	modules/context/api.go
    @andrebruch
    andrebruch committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    500d163 View commit details
    Browse the repository at this point in the history

  3. Remove redundant return statement

    @andrebruch
    andrebruch committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    1459011 View commit details
    Browse the repository at this point in the history

  4. make generate-swagger

    @andrebruch
    andrebruch committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    6d6b858 View commit details
    Browse the repository at this point in the history

  5. Add newline to v1_json.tmpl

    @andrebruch
    andrebruch committed Oct 21, 2021
    Configuration menu
    Copy the full SHA
    6517302 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2021

  1. [API] Add integration tests for issue attachments 

    Signed-off-by: Andre Bruch <ab@andrebruch.com>
    @andrebruch
    andrebruch committed Oct 23, 2021
    Configuration menu
    Copy the full SHA
    cbd1a77 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2021

  1. Merge branch 'main' into feature-add-issue-and-comment-attachments-api

    @6543
    6543 committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    992b8ec View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2021

  1. [API] Add integration tests for comment attachments 

    Signed-off-by: Andre Bruch <ab@andrebruch.com>
    @andrebruch
    andrebruch committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    9227070 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature-add-issue-and-comment-attachments-api

    @6543
    6543 committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    d05625b View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2022

  1. Merge branch 'master' into feature-add-issue-and-comment-attachments-api

    @6543
    6543 committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    e39c3de View commit details
    Browse the repository at this point in the history

  2. adapt latest refactors

    @6543
    6543 committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    fbab446 View commit details
    Browse the repository at this point in the history

  3. rm merge conflict resolve

    @6543
    6543 committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    c8cafc0 View commit details
    Browse the repository at this point in the history

  4. format & fix

    @6543
    6543 committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    5bd533c View commit details
    Browse the repository at this point in the history