Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent endless loop if templates missing #14752

Merged
merged 3 commits into from Feb 20, 2021
Merged

Prevent endless loop if templates missing #14752

merged 3 commits into from Feb 20, 2021

Conversation

zeripath
Copy link
Contributor

Since the chi upgrade if the templates are missing an endless loop will occur if
status/500.tmpl is missing.

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Prevent endless loop if templates missing
6bf4795 
Since the chi upgrade if the templates are missing an endless loop will occur if
status/500.tmpl is missing.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/bug issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself labels Feb 19, 2021
@zeripath zeripath added this to the 1.14.0 milestone Feb 19, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 19, 2021
@lunny
Copy link
Member

lunny commented Feb 20, 2021

So 404 is also have the same problem?

@techknowlogick
Copy link
Member

@lunny I think an error 500 should happen if 404 template (or other templates) are not available, and if one template is not available then likely more aren't available too. So this PR is a good way to solve it.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 20, 2021
@lunny lunny merged commit 65c940f into go-gitea:master Feb 20, 2021
@zeripath zeripath deleted the prevent-endless-loop-if-no-templates branch February 20, 2021 04:27
@zeripath zeripath added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 20, 2021
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zeripath @lunny @techknowlogick @6543 @GiteaBot