Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent endless loop if templates missing #14752

Merged
merged 3 commits into from Feb 20, 2021
Merged

Prevent endless loop if templates missing #14752

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6bf4795
Prevent endless loop if templates missing
zeripath Feb 19, 2021
ab50e44
Merge branch 'master' into prevent-endless-loop-if-no-templates
6543 Feb 19, 2021
5c6d709
Merge branch 'master' into prevent-endless-loop-if-no-templates
techknowlogick Feb 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions modules/context/context.go
View file
Open in desktop
Expand Up @@ -188,6 +188,10 @@ func (ctx *Context) HTML(status int, name base.TplName) {
return fmt.Sprint(time.Since(startTime).Nanoseconds()/1e6) + "ms"
}
if err := ctx.Render.HTML(ctx.Resp, status, string(name), ctx.Data); err != nil {
if status == http.StatusInternalServerError && name == base.TplName("status/500") {
ctx.PlainText(http.StatusInternalServerError, []byte("Unable to find status/500 template"))
return
}
ctx.ServerError("Render failed", err)
}
}
Expand Down