-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Bleve and Elastic code indexers to use a common cat-file --batch #14781
Merged
techknowlogick
merged 9 commits into
go-gitea:master
from
zeripath:batch-cat-files-in-index
Mar 4, 2021
Merged
Move Bleve and Elastic code indexers to use a common cat-file --batch #14781
techknowlogick
merged 9 commits into
go-gitea:master
from
zeripath:batch-cat-files-in-index
Mar 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Thornton <art27@cantab.net>
… indexing Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
6543
approved these changes
Feb 27, 2021
Codecov Report
@@ Coverage Diff @@
## master #14781 +/- ##
==========================================
- Coverage 42.21% 42.20% -0.02%
==========================================
Files 767 771 +4
Lines 81624 82093 +469
==========================================
+ Hits 34458 34646 +188
- Misses 41531 41800 +269
- Partials 5635 5647 +12
Continue to review full report at Codecov.
|
lafriks
approved these changes
Mar 4, 2021
🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
performance/memory
Performance issues affecting memory use
performance/speed
performance issues with slow downs
type/enhancement
An improvement of existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both bleve and elastic code indexers will call cat-file blob blobsha repeatedly for each file indexed. By using a single cat-file --batch we can reduce these multiple calls to a single common cat-file batch.
Signed-off-by: Andrew Thornton art27@cantab.net