Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil exeption for pull reviews API #15104 #15106

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

a1012112796
Copy link
Member

same with master branch

if user == nil {
return nil
}

fix #15104

Signed-off-by: a1012112796 <1012112796@qq.com>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 22, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 22, 2021
@techknowlogick techknowlogick merged commit a6290f6 into go-gitea:release/v1.13 Mar 22, 2021
@techknowlogick
Copy link
Member

@a1012112796 please send backport :)

@a1012112796
Copy link
Member Author

@techknowlogick not need backport, this change target to release/v1.13, and the other versions has been changed by #12856. Thanks

@techknowlogick
Copy link
Member

Thanks :)

@6543 6543 added the modifies/api This PR adds API routes or modifies them label Mar 23, 2021
@6543 6543 changed the title quick fix #15104 Fix nil exeption for pull reviews API #15104 Mar 23, 2021
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants