New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added URL mapping for Release attachments like on github.com #1707

Merged
merged 23 commits into from Jan 6, 2019

Conversation

8 participants
@gdeverlant
Copy link
Contributor

gdeverlant commented May 11, 2017

Implement a Git Hub style URL mapping for the attachment files in Release.

image

Show resolved Hide resolved models/attachment.go Outdated
@gdeverlant

This comment has been minimized.

Copy link
Contributor

gdeverlant commented May 12, 2017

If this doesn't pass then I'm not giving anything more!

ergü added some commits May 15, 2017

Show resolved Hide resolved modules/util/file.go Outdated
ergü

@lunny lunny added this to the 1.3.0 milestone Jun 18, 2017

@lunny lunny modified the milestones: 1.3.0, 1.x.x Oct 11, 2017

@techknowlogick

This comment has been minimized.

Copy link
Member

techknowlogick commented Oct 29, 2018

@gdeverlant would you be able to resolve conflicts as well as update per @lafriks's suggestion?

@stale

This comment has been minimized.

Copy link

stale bot commented Jan 4, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the stale label Jan 4, 2019

lafriks added some commits Jan 6, 2019

@stale stale bot removed the stale label Jan 6, 2019

lafriks added some commits Jan 6, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 6, 2019

Codecov Report

Merging #1707 into master will decrease coverage by 0.01%.
The diff coverage is 4.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1707      +/-   ##
==========================================
- Coverage   37.82%   37.81%   -0.02%     
==========================================
  Files         322      322              
  Lines       47498    47544      +46     
==========================================
+ Hits        17966    17977      +11     
- Misses      26944    26982      +38     
+ Partials     2588     2585       -3
Impacted Files Coverage Δ
routers/repo/repo.go 20.82% <0%> (-1.94%) ⬇️
models/attachment.go 43.62% <0%> (-3.48%) ⬇️
models/release.go 52.8% <0%> (-0.96%) ⬇️
routers/routes/routes.go 85.01% <100%> (+0.04%) ⬆️
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️
models/repo_indexer.go 48.3% <0%> (+3.81%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd006db...926e486. Read the comment docs.

@techknowlogick techknowlogick modified the milestones: 1.x.x, 1.8.0 Jan 6, 2019

@bkcsoft bkcsoft added lgtm/need 1 and removed lgtm/need 2 labels Jan 6, 2019

@lafriks

lafriks approved these changes Jan 6, 2019

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Jan 6, 2019

@techknowlogick techknowlogick merged commit d3dc07f into go-gitea:master Jan 6, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment